Skip to content

Commit 3083af4

Browse files
committed
core controller/model/module structure changes
1 parent 66edfc1 commit 3083af4

8 files changed

Lines changed: 39 additions & 22 deletions

File tree

MODULES_5.5.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,6 @@ A refactor in 5.5 changed most of the structure of the core code. In practically
44

55
- Module update files no longer extend `OBUpdate`, but instead extend `OpenBroadcaster\Base\Update`.
66
- Cron files now extend `OpenBroadcaster\Base\Cron`
7+
- Module controllers go from `OBFController` -> `OpenBroadcaster\Base\Controller`
8+
- Module models go from `OBFModel` -> `OpenBroadcaster\Base\Model`
9+
- Module top level file goes from `OBFModule` -> `OpenBroadcaster\Base\Module`
Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,16 @@
33
// Copyright 2012-2024 OpenBroadcaster, Inc.
44
// SPDX-License-Identifier: AGPL-3.0-or-later
55

6+
namespace OpenBroadcaster\Base;
7+
68
/**
79
* Manages controllers. Makes frameworks available, adds associated controller
810
* request handlers, and methods get called when calling methods on associated
911
* models.
1012
*
1113
* @package Class
1214
*/
13-
class OBFController
15+
class Controller
1416
{
1517
public $load;
1618
public $db;
@@ -22,17 +24,17 @@ class OBFController
2224
protected $callback_handler;
2325

2426
/**
25-
* Create a new instance of OBFController. Makes various classes of OB available
27+
* Create a new instance of Controller. Makes various classes of OB available
2628
* by default, such as OBFLoad, OBFDB, OBFUser, OBFCallbacks, and OBFHelpers.
2729
*/
2830
public function __construct()
2931
{
30-
$this->load = OBFLoad::get_instance();
31-
$this->db = OBFDB::get_instance();
32-
$this->user = OBFUser::get_instance();
33-
$this->callback_handler = OBFCallbacks::get_instance();
34-
$this->helpers = OBFHelpers::get_instance();
35-
$this->models = OBFModels::get_instance();
32+
$this->load = \OBFLoad::get_instance();
33+
$this->db = \OBFDB::get_instance();
34+
$this->user = \OBFUser::get_instance();
35+
$this->callback_handler = \OBFCallbacks::get_instance();
36+
$this->helpers = \OBFHelpers::get_instance();
37+
$this->models = \OBFModels::get_instance();
3638
}
3739

3840
/**
Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,14 @@
33
// Copyright 2012-2024 OpenBroadcaster, Inc.
44
// SPDX-License-Identifier: AGPL-3.0-or-later
55

6+
namespace OpenBroadcaster\Base;
7+
68
/**
79
* Model class. Defines basic OB model functionality.
810
*
911
* @package Class
1012
*/
11-
class OBFModel
13+
class Model
1214
{
1315
public $load;
1416
public $db;
@@ -25,12 +27,12 @@ class OBFModel
2527
*/
2628
public function __construct()
2729
{
28-
$this->load = OBFLoad::get_instance();
29-
$this->db = OBFDB::get_instance();
30-
$this->user = OBFUser::get_instance();
31-
$this->callback_handler = OBFCallbacks::get_instance();
32-
$this->helpers = OBFHelpers::get_instance();
33-
$this->models = OBFModels::get_instance();
30+
$this->load = \OBFLoad::get_instance();
31+
$this->db = \OBFDB::get_instance();
32+
$this->user = \OBFUser::get_instance();
33+
$this->callback_handler = \OBFCallbacks::get_instance();
34+
$this->helpers = \OBFHelpers::get_instance();
35+
$this->models = \OBFModels::get_instance();
3436
}
3537

3638
/**
Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,14 @@
33
// Copyright 2012-2025 OpenBroadcaster, Inc.
44
// SPDX-License-Identifier: AGPL-3.0-or-later
55

6+
namespace OpenBroadcaster\Base;
7+
68
/**
79
* Manages modules.
810
*
911
* @package Class
1012
*/
11-
class OBFModule
13+
class Module
1214
{
1315
public $db;
1416
public $callback_handler;
@@ -19,8 +21,8 @@ class OBFModule
1921
*/
2022
public function __construct()
2123
{
22-
$this->db = OBFDB::get_instance();
23-
$this->callback_handler = OBFCallbacks::get_instance();
24+
$this->db = \OBFDB::get_instance();
25+
$this->callback_handler = \OBFCallbacks::get_instance();
2426
}
2527

2628
/**

modules/logger/controllers/logger.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@
33
// Copyright 2012-2024 OpenBroadcaster, Inc.
44
// SPDX-License-Identifier: AGPL-3.0-or-later
55

6-
class Logger extends OBFController
6+
use OpenBroadcaster\Base\Controller;
7+
8+
class Logger extends Controller
79
{
810

911
public function __construct()

modules/logger/models/logger_model.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@
33
// Copyright 2012-2024 OpenBroadcaster, Inc.
44
// SPDX-License-Identifier: AGPL-3.0-or-later
55

6-
class LoggerModel extends OBFModel
6+
use OpenBroadcaster\Base\Model;
7+
8+
class LoggerModel extends Model
79
{
810

911
public function log($hook,$position,&$args)

modules/logger/module.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@
33
// Copyright 2012-2025 OpenBroadcaster, Inc.
44
// SPDX-License-Identifier: AGPL-3.0-or-later
55

6-
class LoggerModule extends OBFModule
6+
use OpenBroadcaster\Base\Module;
7+
8+
class LoggerModule extends Module
79
{
810

911
public $name = 'Logger v1.0';

modules/tutorial/module.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@
33
// Copyright 2012-2025 OpenBroadcaster, Inc.
44
// SPDX-License-Identifier: AGPL-3.0-or-later
55

6-
class TutorialModule extends OBFModule
6+
use OpenBroadcaster\Base\Module;
7+
8+
class TutorialModule extends Module
79
{
810

911
public $name = 'Tutorial v1.0';

0 commit comments

Comments
 (0)