-
-
Notifications
You must be signed in to change notification settings - Fork 47
The same dropout value is used for all NaNs #402
Copy link
Copy link
Open
Labels
bugSomething isn't workingSomething isn't workingocf-internalAn issue to be addressed internally by Open Climate Fix and not suitable for external contributorsAn issue to be addressed internally by Open Climate Fix and not suitable for external contributorson-hold
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingocf-internalAn issue to be addressed internally by Open Climate Fix and not suitable for external contributorsAn issue to be addressed internally by Open Climate Fix and not suitable for external contributorson-hold
The implementation of the configurable dropout value is problematic or misleading. In the config, it states that it is used to replace values that are dropped out, but in reality is it used to replace any NaN values in the data. This could be NaNs that are in the raw zarr - which is possible with satellite data at least.
We should define what the desired behaviour is and make this NaN filling more clear