-
-
Notifications
You must be signed in to change notification settings - Fork 47
Spatial slice window may not include location #411
Copy link
Copy link
Open
Labels
bugSomething isn't workingSomething isn't workingocf-internalAn issue to be addressed internally by Open Climate Fix and not suitable for external contributorsAn issue to be addressed internally by Open Climate Fix and not suitable for external contributors
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingocf-internalAn issue to be addressed internally by Open Climate Fix and not suitable for external contributorsAn issue to be addressed internally by Open Climate Fix and not suitable for external contributors
In the current spatial slicing the exact position of the target can be offset or even outside the slice.
In the code, we calculate the index closest to the location. Then we slice around it.
This leads to some unexpected behaviour where the slice may not include the location. See B in the diagram below where the closest grid point is to the left of the location.
This could be solved in a bunch of ways which make the location more central in the slice, but will break backwards compatibility