Skip to content

Commit 0f84f67

Browse files
test: search_by_course_id tests fixed
1 parent e251772 commit 0f84f67

2 files changed

Lines changed: 7 additions & 4 deletions

File tree

notesapi/v1/tests/test_views.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -958,8 +958,9 @@ def test_search_by_course_id(self, is_es_disabled):
958958
Tests searching with `course_id` provided
959959
"""
960960

961-
self._create_annotation(text='First one. I am a simple note.', course_id="u'edX/DemoX/Demo_Course'")
962-
self._create_annotation(text='Second note. I am a simple note.', course_id="u'edX/DemoX/Demo_Course'")
961+
self._create_annotation(text='First one. I am a simple note.', course_id="edX/DemoX/Demo_Course")
962+
self._create_annotation(text='Second note. I am a simple note.', course_id="edX/DemoX/Demo_Course")
963+
self._create_annotation(text='Second note. I am a simple note.', course_id="edX/DemoX-v1:Demo+Demo_Course")
963964
self._create_annotation(text='Third note. I am a simple note.', course_id='b')
964965
self._create_annotation(text='Fourth note. I am a simple note.', course_id='c')
965966

@@ -968,8 +969,10 @@ def verify_course_id_search():
968969
"""
969970
Verify search results based on course id operation.
970971
"""
971-
results = self._get_search_results(course_id="u'edX/DemoX/Demo_Course'", text='I am a simple note')
972+
results = self._get_search_results(course_id="edX/DemoX/Demo_Course", text='I am a simple note')
972973
self.assertEqual(results['total'], 2)
974+
results = self._get_search_results(course_id="edX/DemoX-v1:Demo+Demo_Course", text='I am a simple note')
975+
self.assertEqual(results['total'], 1)
973976

974977
results = self._get_search_results(course_id="b", text='I am a simple note')
975978
self.assertEqual(results['total'], 1)

notesapi/v1/views/elasticsearch.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ class AnnotationSearchView(BaseAnnotationSearchView):
3434

3535
# https://django-elasticsearch-dsl-drf.readthedocs.io/en/latest/advanced_usage_examples.html
3636
filter_fields = {
37-
"course_id": "course_id.keywords",
37+
"course_id": "course_id.keyword",
3838
"user": "user",
3939
"usage_id": {
4040
"field": "usage_id",

0 commit comments

Comments
 (0)