Skip to content

feat: adds pending tasks and close modal button#205

Merged
wgu-jesse-stewart merged 5 commits into
openedx:mainfrom
WGU-Open-edX:wgu-jesse-stewart/111-certificates-fixes2
May 13, 2026
Merged

feat: adds pending tasks and close modal button#205
wgu-jesse-stewart merged 5 commits into
openedx:mainfrom
WGU-Open-edX:wgu-jesse-stewart/111-certificates-fixes2

Conversation

@wgu-jesse-stewart
Copy link
Copy Markdown
Contributor

@wgu-jesse-stewart wgu-jesse-stewart commented May 12, 2026

Closes: #107
Closes: #109

Description

Fixes certificate invalidation error modal by adding a close button, allowing users to dismiss validation error messages.

Issue: When certificate invalidation partially failed (e.g., some learners had validation errors), the error modal displayed without any way to close it, forcing users to refresh the page.

Screen.Recording.2026-05-12.at.6.13.21.PM.mov

Changes:

  • Added confirmText: "Close" parameter to the invalidation error modal in CertificatesPage
  • Fixed AlertProvider to properly handle modals with only a confirm button (no onConfirm callback)
  • Added PendingTasks component to Certificates page to display background task status

User Impact: Course Authors using the Instructor Dashboard Certificates tool can now properly dismiss error messages when certificate invalidation encounters validation errors.

Supporting information

Related to certificate invalidation workflow improvements in the Instructor Dashboard.

Testing instructions

  1. Navigate to Instructor Dashboard � Certificates
  2. Click "Invalidate Certificate"
  3. Enter a username that will trigger a validation error (e.g., testeststest - a user that doesn't exist)
  4. Click "Save"
  5. Verify the error modal appears with message "Some invalidations failed: testeststest: User matching query does not exist."
  6. Verify a "Close" button is visible in the modal footer
  7. Click the "Close" button
  8. Verify the modal dismisses properly
  9. Scroll down below the data table and verify the Pending Tasks collapsible section is present

Other information

  • No dependencies or migrations required
  • The PendingTasks component follows the same pattern used in the Grading page

Best Practices Checklist

  • Any new files are using TypeScript (.ts, .tsx).
  • Deprecated propTypes, defaultProps, and injectIntl patterns are not used in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Imports avoid using ../. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

@openedx-webhooks
Copy link
Copy Markdown

openedx-webhooks commented May 12, 2026

Thanks for the pull request, @wgu-jesse-stewart!

This repository is currently maintained by @openedx/committers-frontend-app-instructor-dashboard.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels May 12, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions May 12, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.77%. Comparing base (a1d315c) to head (84e80d3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #205   +/-   ##
=======================================
  Coverage   90.76%   90.77%           
=======================================
  Files         147      147           
  Lines        2621     2623    +2     
  Branches      559      559           
=======================================
+ Hits         2379     2381    +2     
  Misses        236      236           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wgu-jesse-stewart wgu-jesse-stewart marked this pull request as ready for review May 12, 2026 22:39
@wgu-jesse-stewart wgu-jesse-stewart merged commit 4285e07 into openedx:main May 13, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Contributions May 13, 2026
@openedx-semantic-release-bot
Copy link
Copy Markdown

🎉 This PR is included in version 1.0.0-alpha.41 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U released on @latest

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Ticket - Invalidate Certificates Ticket - Certificates Outline/ Page Actions

4 participants