[Feature]: Dashboard (EOC) turn off facilities.

[cbyrdmo]

What problem are you trying to solve?

When looking at the EOC dashboard there is no option to turn off facilities. On the main screen there is an option to do this.

What would you like it to do?

Have an option to disable the display of facilities and other items as on the situation screen map.

How do you handle it now?

No response

What kind of group are you in?

None

Who do you think needs this?

Likely useful to most groups running TicketsCAD

Could you help build or test it? (optional)

No response

[rjonesbsink]

An observation that might change how this one is categorised — it looks like the
feature already exists on the EOC display and simply never appears in the layer
control. Reading only, so treat this as a pointer rather than a diagnosis; the fix is
yours.

What I think is happening

situation.php builds its layer control into a local variable:

// situation.php:632
var sitLayersControl = L.control.layers(baseMaps, overlays, { collapsed: true, position: 'topright' }).addTo(map);

but the two functions that would register Units and Facilities check a global
instead:

// situation.php:1172  ensureFacilityLayer()
facMarkers.addTo(mapVar());
if (window._mapLayersControl && !window._eocFacsInCtl) {
    window._mapLayersControl.addOverlay(facMarkers, '… Facilities (EOC)');
    window._eocFacsInCtl = true;
}

window._mapLayersControl is assigned in exactly one place in the tree —
assets/js/app.js:1050, where the dashboard map builds its own control — and
situation.php doesn't load app.js. I checked every script it does load
(map-prefs, map-image-overlays, screen-prefs, unit-tracking, event-bus,
facility-status, leaflet-quadkey, leaflet-mobile-fit) and none of them
references it either.

So on the EOC display that condition is always false, addOverlay never runs, and
neither Units (EOC) nor Facilities (EOC) is ever listed. The markers are still
added to the map on the line above, which produces exactly what @cbyrdmo describes:
facilities visible, no way to switch them off.

Everything else in the file uses the local sitLayersControl — lines 660, 670–672,
683–685, 695 and 748 — so these two functions read like they were adapted from the
dashboard and kept the dashboard's global by accident.

Why this may be more than cosmetic

The persistence half is already wired. Both functions call:

window.MapLayerPrefs.register(mapVar(), 'facilities', facMarkers);

and the comment right above it references the original request — "I don't want to see
my facilities on my map but I want to load them if I need them." So the intended
behaviour, including remembering the choice across reloads, appears to be fully built
on this screen; the checkbox that would drive it is the only piece missing.

If that reading is right, this is closer to a regression than a feature request, which
might affect how you want to schedule it.

Caveat, stated plainly: this is static reading. situation.php needs a session and
I didn't want to guess at what a logged-in run would show, so I have not watched it
fail in a browser — only traced why it would. Worth a sanity check before acting on it.

Happy to test a patch on 4.2.14 / Windows / IIS if that's useful.

[ejosterberg]

That lines up with what I'd expect from a quick look — appreciate you tracing it to the actual line. Sounds like a small, contained fix (the layer control already exists and works elsewhere; this is about it not being exposed on this one view) rather than new functionality. Leaving open for Eric to slot in.

[ejosterberg]

@rjonesbsink — fixed exactly where you pointed. ensureFacilityLayer()/ensureUnitLayer() were checking window._mapLayersControl, which only the dashboard ever sets (app.js), while situation.php builds its own local sitLayersControl and never touches that global. Both functions now register against the local control, same as everything else on the page. Units (EOC) and Facilities (EOC) show up in the layer control and the toggle persists across reloads, same as the dashboard. Shipped in v4.2.15, live on training and Bloomington.

[ejosterberg]

@rjonesbsink — can you confirm and close this one if it's resolved on your end?

[cbyrdmo]

on the situation dashboard (EOC) this the menu i get

No options to turn off incidents,responders and facilties

This is the menu on the main situation screen

So if you are looking at the EOC display and do not want to show facilities there is no option to turn them off.

[ejosterberg]

Looking at both screenshots: the first one (no facilities/units/incidents toggle, just markup categories and weather) is the EOC Display page (situation.php -- its own page title is literally "EOC Display"). The second one (has Incidents/Responders/Facilities checkboxes) is the regular Dashboard's map widget.

The EOC Display's Units/Facilities toggles were broken exactly the way you're describing, and I shipped a fix for that on 2026-08-11 (v4.2.17) -- they were rendering on the map but had no way to turn them off because of a naming bug in the JS. If you're running v4.2.17 or later and still see the menu in your first screenshot, two things to check:

1. A hard refresh (Ctrl+F5 / Cmd+Shift+R) on the EOC Display page -- the fix is JS-side and a cached copy of the old file would still show the old menu.
2. What version you're actually on (About page, or the version badge in the navbar) -- if you're on an older build, Already up to date. (or your usual update path) will bring the fix in.

One more thing worth flagging while I'm looking at this: even after that fix, the EOC Display has no "Incidents" toggle at all -- incidents always render there, only Units and Facilities are toggleable. If hiding incidents specifically (not just units/facilities) is part of what you need, that's a separate, not-yet-built piece -- let me know and I'll add it.

[cbyrdmo]

I did the ctrl F5 and I am running 4.2.17 in google chome. Still displays the way I described. Opened firefox. Tried the exact same thing. Same results. Clicked reset to default. No change. Deleted all site data. No change.... Something is not getting updated. If I do a git pull on the testcad system it says 'Already up to date'

Here is the about window

[ejosterberg]

@cbyrdmo @rjonesbsink -- my last comment here (asking about hard refresh / version) was the wrong diagnosis. You were both already on the version that should have had the fix, and a hard refresh wouldn't have changed anything, because the fix itself didn't actually work. Sorry for sending you chasing a cache issue that wasn't there.

Real root cause, found by reproducing this live in a browser rather than reading the diff again: the 2026-08-11 fix correctly swapped window._mapLayersControl (a global situation.php never sets) for sitLayersControl, the local variable every other overlay on the page already uses -- but sitLayersControl was declared with var inside initMap(), a JavaScript function. ensureUnitLayer() and ensureFacilityLayer() are separate, sibling functions -- they can't see a variable declared local to a different function. So the very first time either ran, it threw sitLayersControl is not defined, and that error was silently swallowed by an empty .catch() on the fetch chain that calls them -- no console error, nothing to see, the markers still drew on the map, just never got listed in the layer control. Right idea, wrong scope, and nothing short of loading the real page and watching it fail was going to catch that from a diff.

Fixed by declaring the shared variable at the top level of the script (same place map/tileLayer/markerGroup already live) and having initMap() assign to it instead of re-declaring it locally. Also made those catch handlers log instead of swallow, so this class of bug can't hide silently again.

Verified live in a browser this time, not just read from the code: Units (EOC) and Facilities (EOC) both now appear in the layer control and toggle correctly, confirmed on training and Bloomington.

This hasn't gone out in a tagged release yet -- that's a separate step from landing the fix -- so a git pull against this repo's current release tag won't have it. I'll follow up here once it ships.

[ejosterberg]

Update: this is out now. v4.2.18 is published (https://github.com/openises/TicketsCAD/releases/tag/v4.2.18), so a git pull on the current release will bring in the real fix. Units (EOC) and Facilities (EOC) both show up in the layer control and toggle correctly -- confirmed again on the actual v4.2.18 build, not just in the dev tree.