[Bug]: Situation (EOC) Units location not updating

[cbyrdmo]

Which version are you running?

4.2.22

How is it installed?

Git clone on Windows (XAMPP or similar)

What page or screen were you on?

Situation EOC Dashboard

What went wrong?

Sorry I did not catch this sooner, I only run traccar data in my production system. I just notice that the units locations are not updating on the EOC Screen. They are correct on the main dashboard. I think the locations maybe updating but the unit status window is not showing the update.

Only the test units and truck 207 are traccar connected currently

Truck 207 should show updates as the ingest shows activity.
EOC Status shows 10d ago.

Main Dashboard Map

EOC Status

EOC Map

What steps lead to it?

No response

Screenshot (optional)

No response

What device / browser?

No response

[rjonesbsink]

@cbyrdmo what location service are you using on your test cad

[cbyrdmo]

Traccar. Ingest is showing activity.

[ethanhawkes-gif]

A focused fix for the Traccar staleness display is available in PR #72. Could you test the updated-age behavior and let us know whether it resolves the issue and is helpful for your dispatch workflow?

[cbyrdmo]

I am not sure how to do the test you are requesting. I have switched Traccar to my test system to do the test if you can help with that.

[rjonesbsink]

@cbyrdmo — the test is simpler than it sounds, and you don't need the console
or any tooling. You're watching one number.

What you're checking: whether the Units table's Updated column moves when
a GPS position arrives, if the unit's status hasn't changed.

1. On your test system, pick one Traccar-connected unit (Truck 207 if it's on
   there) and leave it in whatever status it's in — don't touch its status
2. Open the Situation (EOC) screen and find that unit's row
3. Note the Updated value — it'll be something like "12m"
4. Confirm Traccar ingest is still active for it (the main dashboard showing the
   unit moving is enough)
5. Wait a few minutes and look at the Updated column again

Result that confirms the bug: the age keeps climbing — 12m, 15m, 20m — even
though positions are arriving. It's counting from the last status change, not
the last position.

Result that means it's fixed: the age drops back to seconds each time a
position lands.

That's the whole test. If you can watch the main dashboard and the EOC screen
side by side, better still — the dashboard should show recent movement while the
EOC Updated column keeps ageing.

---

For what it's worth, I can confirm the cause from my own install (4.2.22,
unmodified). The EOC Units row builds that cell from status only:

// situation.php:1486
sitAgo(u.status_updated || u.updated)

while api/responders.php:538 does resolve and send a tracking timestamp:

'last_track' => $effLastAt,

So the data is reaching the page and that column isn't looking at it — which
matches exactly what you described, and explains why the main dashboard is right
while the EOC screen isn't. I don't run Traccar here, so I can't reproduce the
live behaviour, only the code path.

[cbyrdmo]

I check and the map shows the last fix was 2s ago but the update shows 10d ago. Location ingest shows the unit stats are updating.

[ethanhawkes-gif]

Thanks — that side-by-side result (map shows the last fix 2s ago while the Updated column shows 10d ago, with ingest active) confirms exactly the defect PR #72 fixes.

To try the fix on your test system you only need to edit one file, situation.php (back it up first, e.g. cp situation.php situation.php.bak):

1. Find the line containing:

sitAgo(u.status_updated || u.updated)

and change that call to:

sitLatestAgo(u.last_track, u.status_updated, u.updated)

2. Find function sitAgo( (the small helper that produces "12m ago" etc.), and right after its closing } add:

    // A GPS fix is a unit update too. Keep the EOC Units table aligned with
    // the map by showing the newest of the tracking, status, and unit-row
    // timestamps instead of reporting an old status change while fresh
    // Traccar/OwnTracks positions continue to arrive.
    function sitLatestAgo() {
        var latest = '';
        var latestMs = -Infinity;
        var fallback = '';
        for (var i = 0; i < arguments.length; i++) {
            var value = arguments[i];
            if (!value) continue;
            if (!fallback) fallback = value;
            var parsed = new Date(String(value).replace(' ', 'T')).getTime();
            if (!isNaN(parsed) && parsed > latestMs) {
                latest = value;
                latestMs = parsed;
            }
        }
        return sitAgo(latest || fallback);
    }

3. Hard-refresh the Situation/EOC screen (Ctrl+Shift+R).

Expected result: the Updated cell for your Traccar-connected unit drops back to seconds each time a position lands (matching the map), while units without tracking behave exactly as before.

If you prefer replacing the whole file, the fully patched situation.php from the PR is here: https://raw.githubusercontent.com/ethanhawkes-gif/TicketsCAD/fix/eoc-unit-tracking-updated-71/situation.php — but the two-edit route above is safer if your install isn't on the latest master.

If it resolves it on your test system, a short confirmation here would help get PR #72 merged so you get it in a normal update.

[cbyrdmo]

Made the changes and it is updating.

Did notice one issue. If you disable units on the hamburger menu. The units still appear on the map. They are now orange instead of green.

[ethanhawkes-gif]

Great — thanks for confirming the Updated column now tracks live positions on your test system. That verifies the fix in PR #72.

The orange-markers behavior is separate from this patch: PR #72 only changes how the Updated text in the EOC Units table is computed — it does not touch map markers, layers, or colors. Two details would pin down what you are seeing:

1. Where did you disable the units — the layers control on the map itself (the Units (EOC) checkbox under the layers icon), or somewhere else (e.g. the unit's status or admin page)?
2. If you click one of the orange markers, what does the status badge in the popup say? Orange is the default marker color for an On Scene status (or any custom status color configured under Unit Statuses), so the color may be reflecting a status rather than the disable action.

If you open that as a separate issue with those two details, it can be tracked and fixed on its own — it does look like a real visibility bug worth running down.

[cbyrdmo]

I disabled the units with this menu

The orange marker show this

[ethanhawkes-gif]

Thanks — those two screenshots nailed it. That's a real bug, and it's separate from the Updated-column fix.

In plain terms: your situation board actually draws each unit twice — once as the coloured status dot (green when Available), and once as a live-GPS marker fed straight from Traccar (that's the orange one with the "Last fix: 4s ago" popup). The Units (EOC) checkbox in that layers menu only turns off the first one. The live-GPS markers were wired directly onto the map with no checkbox of their own, so when you switch units off the green dots disappear but the orange Traccar markers stay put — exactly what you saw. The green→orange "change" is just those two layers using different colours for the same trucks.

I filed it as its own bug (#74) and put up a fix (#75): it gives the live-GPS markers their own "Units — live GPS" checkbox in that same layers menu, wired into the same per-user layer-memory the other layers use, so you can hide them too. Default stays on, so nothing changes unless you uncheck it. (One open question for the maintainers in the PR: whether you'd rather the single Units (EOC) box just hide both — if that's the more natural behavior for you, say so and I'll steer it that way.)

Separately, and only if it's easy to eyeball: roughly how stale was the board getting before the Updated-column fix versus now during a live incident — a few seconds, a minute, several minutes? Just trying to put a number on how much it was actually hurting you.