removed docker from pytest default

Author: satvshr

.github/workflows/test.yml

@@ -107,6 +107,15 @@ jobs:
         git clone --depth 1 https://github.com/openml/server-api.git server-api
         sed -i 's|\.\./server-api|./server-api|g' docker-compose.yml
 
+    - name: Start Docker Test Environment
+      if: matrix.os == 'ubuntu-latest'
+      shell: bash
+      run: |
+        sed -i 's/\r$//' docker/update.sh
+        docker compose up -d
+        docker wait openml-test-setup-ci
+        echo "OPENML_TEST_SERVER=local" >> $GITHUB_ENV
+
     - name: Show installed dependencies
       run: python -m pip list
 

docker-compose.yml

@@ -11,6 +11,11 @@ services:
       start_period: 30s
       interval: 5s
       retries: 10
+    networks:
+          default:
+            aliases:
+              - openml-test-database
+              - elasticsearch
 
   database-setup:
     image: mysql

tests/conftest.py

@@ -24,9 +24,6 @@
 from __future__ import annotations
 
 import multiprocessing
-import sys
-
-import fasteners
 
 multiprocessing.set_start_method("spawn", force=True)
 
@@ -38,9 +35,6 @@
 import pytest
 import openml_sklearn
 
-import time
-import subprocess
-import requests
 import openml
 from openml.testing import TestBase
 
@@ -302,46 +296,18 @@ def with_test_cache(test_files_directory, request):
     if tmp_cache.exists():
         shutil.rmtree(tmp_cache)
 
-def _is_server_responding():
-    """Check if the Docker API is already listening."""
-    try:
-        requests.get("http://localhost:9001/api/v2/", timeout=1)
-        return True
-    except (requests.exceptions.ConnectionError, requests.exceptions.Timeout):
-        return False
-
-def _start_docker():
-    """Logic to spin up the containers and wait for initialization."""
-    subprocess.run(["docker", "compose", "up", "-d"], check=True, capture_output=True, text=True)
-    subprocess.run(["docker", "wait", "openml-test-setup-ci"], check=True)
-
-@pytest.fixture(scope="session", autouse=True)
-def openml_docker_stack(tmp_path_factory, worker_id):
-    # Skip Docker setup in CI on Windows given docker images are for Linux
-    is_ci = os.environ.get("CI") == "true"
-    is_windows = sys.platform == "win32" or os.name == "nt"
-
-    if is_ci and is_windows:
-        yield
-        return
-
-    # For local development with single worker
-    if worker_id == "master":
-        _start_docker()
-        yield
-        subprocess.run(["docker", "compose", "down", "-v"], check=True)
-        return
-
-    # For CI with multiple workers (xdist)
-    root_tmp_dir = tmp_path_factory.getbasetemp().parent
-    lock_file = root_tmp_dir / "docker_setup.lock"
+@pytest.fixture(scope="session")
+def openml_test_config():
+    """
+    Returns the URL for the test server.
+    """
+    if os.environ.get("OPENML_TEST_SERVER") == "local":
+        return {
+            "v1": "http://localhost:9002/api/v1/",
+            "v2": "http://localhost:9001/"
+        }
 
-    lock = fasteners.InterProcessLock(str(lock_file))
-    with lock:
-        if not _is_server_responding():
-            _start_docker()
-
-    yield
+    raise ValueError("Use the environment variable OPENML_TEST_SERVER=local before running docker to run tests against a local OpenML server.")
 
 @pytest.fixture
 def static_cache_dir():