Skip to content

Commit 3029936

Browse files
committed
update tests
1 parent 8701b63 commit 3029936

1 file changed

Lines changed: 2 additions & 33 deletions

File tree

tests/test_api/test_estimation_procedure.py

Lines changed: 2 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import pytest
55
from openml._api import EstimationProcedureV1API, EstimationProcedureV2API
66
from openml.exceptions import OpenMLNotSupportedError
7+
from openml.estimation_procedures import OpenMLEstimationProcedure
78

89

910
@pytest.fixture
@@ -16,48 +17,16 @@ def estimation_procedure_v2(http_client_v2, minio_client) -> EstimationProcedure
1617
return EstimationProcedureV2API(http=http_client_v2, minio=minio_client)
1718

1819

19-
@pytest.mark.test_server()
20-
def test_v1_list(estimation_procedure_v1):
21-
procedures = estimation_procedure_v1.list()
22-
23-
assert isinstance(procedures, list)
24-
assert len(procedures) > 0
25-
assert all(isinstance(p, str) for p in procedures)
26-
27-
2820
@pytest.mark.test_server()
2921
def test_v1_list(estimation_procedure_v1):
3022
details = estimation_procedure_v1.list()
3123

3224
assert isinstance(details, list)
3325
assert len(details) > 0
34-
assert all(isinstance(d, dict) for d in details)
35-
36-
assert all("id" in d for d in details)
37-
assert all("name" in d for d in details)
38-
assert all("task_type_id" in d for d in details)
39-
26+
assert all(isinstance(d, OpenMLEstimationProcedure) for d in details)
4027

41-
@pytest.mark.test_server()
42-
def test_v2_list(estimation_procedure_v2):
43-
procedures = estimation_procedure_v2.list()
44-
45-
assert isinstance(procedures, list)
46-
assert len(procedures) > 0
47-
assert all(isinstance(p, str) for p in procedures)
4828

49-
5029
@pytest.mark.test_server()
5130
def test_v2_list(estimation_procedure_v2):
5231
with pytest.raises(OpenMLNotSupportedError):
5332
estimation_procedure_v2.list()
54-
55-
56-
@pytest.mark.test_server()
57-
def test_list_matches(estimation_procedure_v1,estimation_procedure_v2):
58-
output_v1 = estimation_procedure_v1.list()
59-
output_v2 = estimation_procedure_v2.list()
60-
61-
assert isinstance(output_v1, list)
62-
assert isinstance(output_v2, list)
63-
assert output_v1 == output_v2

0 commit comments

Comments
 (0)