new migration tests

Author: JATAYU000

openml/datasets/dataset.py

@@ -959,7 +959,6 @@ def publish(self) -> OpenMLDataset:
         file_elements = self._get_file_elements()
         if "description" not in file_elements:
             file_elements["description"] = self._to_xml()
-
         dataset_id = openml._backend.dataset.publish(path="data", files=file_elements)
         self.dataset_id = dataset_id
         return self

openml/testing.py

@@ -295,6 +295,7 @@ def setUp(self) -> None:
         self.server = "https://test.openml.org/"
         self.base_url = "api/v1/xml"
         self.api_key = "normaluser"
+        self.admin_key = "abc"
         self.timeout = 10
         self.retries = 3
         self.retry_policy = RetryPolicy.HUMAN

tests/test_api/test_datasets.py

@@ -1,9 +1,10 @@
 from __future__ import annotations
 from pathlib import Path
+from time import time
 
+from openml import OpenMLDataset
 import pytest
 import pandas as pd
-from typing import TYPE_CHECKING
 from openml._api.clients.minio import MinIOClient
 from openml._api.resources.base.fallback import FallbackProxy
 from openml.testing import TestAPIBase
@@ -73,6 +74,62 @@ def test_get_qualities(self):
         assert isinstance(output,dict)
         assert len(output.keys()) == 19
 
+    @pytest.mark.uses_test_server()
+    def test_status_update(self):
+        dataset = OpenMLDataset(
+            f"TEST-{str(time())}-UploadTestWithURL",
+            "test",
+            "ARFF",
+            version=1,
+            url="https://www.openml.org/data/download/61/dataset_61_iris.arff",
+        )
+        file_elements= dict()
+        file_elements["description"] = dataset._to_xml()
+        dataset_id = self.dataset.publish(path="data", files=file_elements)
+        self.dataset_id = dataset_id
+        # admin key for test server (only admins can activate datasets.
+        # all users can deactivate their own datasets)
+        self.api_key = self.dataset._http.api_key = self.admin_key
+
+        status = "deactivated"
+        self.dataset.status_update(dataset_id,status)
+        result = self.dataset.list(limit=1,offset=0,data_id=[dataset_id], status="all")
+        result = result.to_dict(orient="index")
+        assert result[dataset_id]["status"] == status
+        
+        status = "active"
+        self.dataset.status_update(dataset_id,status)
+        result = self.dataset.list(limit=1,offset=0,data_id=[dataset_id], status="all")
+        result = result.to_dict(orient="index")
+        assert result[dataset_id]["status"] == status
+
+        assert self.dataset.delete(dataset_id)
+
+    @pytest.mark.uses_test_server()
+    def test_edit(self):pass
+
+    @pytest.mark.uses_test_server()
+    def test_fork(self):pass
+
+    @pytest.mark.uses_test_server()
+    def test_list_qualities(self):
+        output = self.dataset.list_qualities()
+        assert len(output) == 19
+        assert isinstance(output[0],str)
+
+    @pytest.mark.uses_test_server()
+    def test_feature_add_remove_ontology(self):
+        did = 11
+        fid = 0
+        ontology = "https://www.openml.org/unittest/" + str(time())
+        output = self.dataset.feature_add_ontology(did,fid,ontology)
+        assert output
+
+        output = self.dataset.feature_remove_ontology(did,fid,ontology)
+        assert output
+
+    @pytest.mark.uses_test_server()
+    def test_add_remove_topic(self):pass
 
 
 class TestDatasetV2API(TestAPIBase):
@@ -84,7 +141,7 @@ def setUp(self):
         self.client = self._get_http_client(
             server="http://127.0.0.1:8001/",
             base_url="",
-            api_key=self.api_key,
+            api_key="",
             timeout=self.timeout,
             retries=self.retries,
             retry_policy=self.retry_policy,
@@ -138,6 +195,12 @@ def test_get_qualities(self):
         assert isinstance(output,dict)
         assert len(output.keys()) == 107
 
+    @pytest.mark.uses_test_server()
+    def test_list_qualities(self):
+        output = self.dataset.list_qualities()
+        assert len(output) == 107
+        assert isinstance(output[0],str)
+
 
 class TestDatasetsCombined(TestAPIBase):
     def setUp(self):
@@ -157,7 +220,7 @@ def setUp(self):
         self.v2_client = self._get_http_client(
             server="http://127.0.0.1:8001/",
             base_url="",
-            api_key=self.api_key,
+            api_key="",
             timeout=self.timeout,
             retries=self.retries,
             retry_policy=self.retry_policy,
@@ -200,10 +263,11 @@ def test_list_fallback(self):
 
     @pytest.mark.uses_test_server()
     def test_get_features_matches(self):
-        output_v1 = self.dataset_v1.get_features(2)
-        output_v2 = self.dataset_v2.get_features(2)
+        output_v1 = self.dataset_v1.get_features(3)
+        output_v2 = self.dataset_v2.get_features(3)
 
         assert output_v1.keys() == output_v2.keys()
+        # would not be same if v1 has ontology
         assert output_v1 == output_v2
 
     @pytest.mark.uses_test_server()
@@ -215,14 +279,72 @@ def test_get_features_fallback(self):
 
     @pytest.mark.uses_test_server()
     def test_get_qualities_matches(self):
+        #TODO Qualities in local python server and test server differ
         output_v1 = self.dataset_v1.get_qualities(2)
         output_v2 = self.dataset_v2.get_qualities(2)
+        assert output_v1['AutoCorrelation'] == output_v2['AutoCorrelation']
 
-        #TODO Qualities in local python server and test server differ
 
     @pytest.mark.uses_test_server()
     def test_get_qualities_fallback(self):
+        #TODO Qualities in local python server and test server differ
         output_fallback = self.dataset_fallback.get_qualities(2)
 
         assert isinstance(output_fallback,dict)
-        #TODO Qualities in local python server and test server differ
+
+    @pytest.mark.uses_test_server()
+    def test_list_qualities_matches(self):
+        #TODO Qualities in local python server and test server differ
+        output_v1 = self.dataset_v1.list_qualities()
+        output_v2 = self.dataset_v2.list_qualities()
+
+        assert "AutoCorrelation" in output_v1
+        assert "AutoCorrelation" in output_v2
+
+
+    @pytest.mark.uses_test_server()
+    def test_list_qualities_fallback(self):
+        #TODO Qualities in local python server and test server differ
+        output_fallback = self.dataset_fallback.list_qualities()
+
+        assert isinstance(output_fallback,list)
+
+    @pytest.mark.uses_test_server()
+    def test_status_update_fallback(self):
+        dataset = OpenMLDataset(
+            f"TEST-{str(time())}-UploadTestWithURL",
+            "test",
+            "ARFF",
+            version=1,
+            url="https://www.openml.org/data/download/61/dataset_61_iris.arff",
+        )
+        file_elements= dict()
+        file_elements["description"] = dataset._to_xml()
+        dataset_id = self.dataset_fallback.publish(path="data", files=file_elements)
+        self.dataset_id = dataset_id
+        self.api_key = self.dataset_fallback._http.api_key = self.admin_key
+
+        self.dataset_fallback.status_update(dataset_id,"deactivated")
+        self.dataset_fallback.status_update(dataset_id,"active")
+
+        assert self.dataset_fallback.delete(dataset_id)
+
+    @pytest.mark.uses_test_server()
+    def test_edit_fallback(self):pass
+
+    @pytest.mark.uses_test_server()
+    def test_fork_fallback(self):pass
+
+    @pytest.mark.uses_test_server()
+    def test_feature_add_remove_ontology_fallback(self):
+        ontology = "https://www.openml.org/unittest/" + str(time())
+        output_fallback_add = self.dataset_fallback.feature_add_ontology(
+            11, 0,ontology)
+        assert output_fallback_add
+        output_fallback_remove = self.dataset_fallback.feature_remove_ontology(
+            11, 0,ontology)
+        assert output_fallback_remove
+    
+    @pytest.mark.uses_test_server()
+    def test_add_remove_topic_fallback(self):pass
+