Skip to content

Commit 7d4d62e

Browse files
committed
Fixed flow_functions and dataset factorize bugs
1 parent 99928f8 commit 7d4d62e

2 files changed

Lines changed: 7 additions & 6 deletions

File tree

tests/test_datasets/test_dataset.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -105,18 +105,18 @@ def test_get_data_pandas(self):
105105
col_dtype = {
106106
"pclass": "uint8",
107107
"survived": "category",
108-
"name": "object",
108+
"name": "str",
109109
"sex": "category",
110110
"age": "float64",
111111
"sibsp": "uint8",
112112
"parch": "uint8",
113-
"ticket": "object",
113+
"ticket": "str",
114114
"fare": "float64",
115-
"cabin": "object",
115+
"cabin": "str",
116116
"embarked": "category",
117-
"boat": "object",
117+
"boat": "str",
118118
"body": "float64",
119-
"home.dest": "object",
119+
"home.dest": "str",
120120
}
121121
for col_name in data.columns:
122122
assert data[col_name].dtype.name == col_dtype[col_name]

tests/test_flows/test_flow_functions.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,9 @@ def _check_flow(self, flow):
4141
assert isinstance(flow["full_name"], str)
4242
assert isinstance(flow["version"], str)
4343
# There are some runs on openml.org that can have an empty external version
44+
ext_version = flow["external_version"]
4445
ext_version_str_or_none = (
45-
isinstance(flow["external_version"], str) or flow["external_version"] is None
46+
isinstance(ext_version, str) or ext_version is None or pd.isna(ext_version)
4647
)
4748
assert ext_version_str_or_none
4849

0 commit comments

Comments
 (0)