final commit

Author: EmanAbdelhaleem

openml/_api/resources/setup.py

@@ -208,20 +208,20 @@ class SetupV2API(ResourceV2API, SetupAPI):
 
     def list(
         self,
-        limit: int,
-        offset: int,
+        limit: int,  # noqa: ARG002
+        offset: int,  # noqa: ARG002
         *,
-        setup: Iterable[int] | None = None,
-        flow: int | None = None,
-        tag: str | None = None,
+        setup: Iterable[int] | None = None,  # noqa: ARG002
+        flow: int | None = None,  # noqa: ARG002
+        tag: str | None = None,  # noqa: ARG002
     ) -> builtins.list[OpenMLSetup]:
-        raise NotImplementedError("V2 API implementation is not yet available")
+        self._not_supported(method="list")
 
-    def _create_setup(self, result_dict: dict) -> OpenMLSetup:
-        raise NotImplementedError("V2 API implementation is not yet available")
+    def _create_setup(self, result_dict: dict) -> OpenMLSetup:  # noqa: ARG002
+        self._not_supported(method="create_setup")
 
-    def get(self, setup_id: int) -> OpenMLSetup:
-        raise NotImplementedError("V2 API implementation is not yet available")
+    def get(self, setup_id: int) -> OpenMLSetup:  # noqa: ARG002
+        self._not_supported(method="get")
 
-    def exists(self, file_elements: dict[str, Any]) -> int | bool:
-        raise NotImplementedError("V2 API implementation is not yet available")
+    def exists(self, file_elements: dict[str, Any]) -> int | bool:  # noqa: ARG002
+        self._not_supported(method="exists")

tests/test_api/test_setups.py

@@ -4,15 +4,14 @@
 import pytest  
 import hashlib
 import time
-from openml._api.config import settings
 import sklearn.tree
 import sklearn.naive_bayes
 import openml
 from openml_sklearn import SklearnExtension
 from openml.testing import TestBase
 
 
-from openml._api.resources.setups import SetupsV1, SetupsV2
+from openml._api.resources.setup import SetupV1API, SetupV2API
 from openml.setups.setup import OpenMLSetup
 from openml.testing import TestAPIBase
 from openml._api.resources.base.fallback import FallbackProxy
@@ -26,22 +25,22 @@ def get_sentinel():
     sentinel = md5.hexdigest()[:10]
     return f"TEST{sentinel}"  
 
-class TestSetupsV1(TestAPIBase):  
+class TestSetupV1(TestAPIBase):  
     """Tests for V1 XML API implementation of setups."""  
 
     _multiprocess_can_split_ = True  
 
     def setUp(self) -> None:    
         super().setUp() 
         self.client = self._get_http_client(
-            server=settings.api.v1.server,
-            base_url=settings.api.v1.base_url,
-            api_key=settings.api.v1.api_key,
-            timeout=settings.api.v1.timeout,
-            retries=settings.connection.retries,
-            retry_policy=settings.connection.retry_policy,
+            server=self.server,
+            base_url=self.base_url,
+            api_key=self.api_key,
+            timeout_seconds=self.timeout_seconds,
+            retries=self.retries,
+            retry_policy=self.retry_policy,
         )
-        self.resource = SetupsV1(self.client)
+        self.resource = SetupV1API(self.client)
         self.extension = SklearnExtension()
 
     @pytest.mark.uses_test_server()
@@ -111,45 +110,45 @@ def test_exists_existing_setup(self):
         assert setup_id == run.setup_id
 
 
-class TestSetupsV2(TestAPIBase): 
+class TestSetupV2(TestAPIBase): 
     """Tests for V2 JSON API implementation of setups."""  
 
     _multiprocess_can_split_ = True  
 
     def setUp(self) -> None:    
         super().setUp() 
         self.client = self._get_http_client(
-            server=settings.api.v2.server,
-            base_url=settings.api.v2.base_url,
-            api_key=settings.api.v2.api_key,
-            timeout=settings.api.v2.timeout,
-            retries=settings.connection.retries,
-            retry_policy=settings.connection.retry_policy,
+            server=self.server,
+            base_url=self.base_url,
+            api_key=self.api_key,
+            timeout_seconds=self.timeout_seconds,
+            retries=self.retries,
+            retry_policy=self.retry_policy,
         )
-        self.resource = SetupsV2(self.client)
+        self.resource = SetupV2API(self.client)
 
 
 class TestSetupsCombined(TestAPIBase):
     def setUp(self):
         super().setUp()
         self.v1_client = self._get_http_client(
-            server=settings.api.v1.server,
-            base_url=settings.api.v1.base_url,
-            api_key=settings.api.v1.api_key,
-            timeout=settings.api.v1.timeout,
-            retries=settings.connection.retries,
-            retry_policy=settings.connection.retry_policy,
+            server=self.server,
+            base_url=self.base_url,
+            api_key=self.api_key,
+            timeout_seconds=self.timeout_seconds,
+            retries=self.retries,
+            retry_policy=self.retry_policy,
         )
         self.v2_client = self._get_http_client(
-            server=settings.api.v2.server,
-            base_url=settings.api.v2.base_url,
-            api_key=settings.api.v2.api_key,
-            timeout=settings.api.v2.timeout,
-            retries=settings.connection.retries,
-            retry_policy=settings.connection.retry_policy,
+            server=self.server,
+            base_url=self.base_url,
+            api_key=self.api_key,
+            timeout_seconds=self.timeout_seconds,
+            retries=self.retries,
+            retry_policy=self.retry_policy,
         )
-        self.resource_v1 = SetupsV1(self.v1_client)
-        self.resource_v2 = SetupsV2(self.v2_client)
+        self.resource_v1 = SetupV1API(self.v1_client)
+        self.resource_v2 = SetupV2API(self.v2_client)
         self.resource_fallback = FallbackProxy(self.resource_v2, self.resource_v1)
         self.extension = SklearnExtension()