Skip to content

Commit 9b2c0db

Browse files
committed
test fix
1 parent 1858a98 commit 9b2c0db

1 file changed

Lines changed: 6 additions & 21 deletions

File tree

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteExplainIT.java

Lines changed: 6 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -2955,14 +2955,8 @@ public void testXyseriesExplain() throws IOException {
29552955
+ " | xyseries state gender in (\"F\", \"M\") avg_balance",
29562956
TEST_INDEX_BANK));
29572957
var result = explainQueryYaml(query);
2958-
String lower = result.toLowerCase();
2959-
Assert.assertTrue(
2960-
"Expected explain to contain LogicalAggregate for pivot grouping",
2961-
lower.contains("logicalaggregate") || lower.contains("aggregate"));
2962-
Assert.assertTrue(
2963-
"Expected explain to contain CASE expression for pivot", lower.contains("case"));
2964-
Assert.assertTrue("Expected explain to contain pivot value 'F'", result.contains("F"));
2965-
Assert.assertTrue("Expected explain to contain pivot value 'M'", result.contains("M"));
2958+
String expected = loadExpectedPlan("explain_xyseries.yaml");
2959+
assertYamlEqualsIgnoreId(expected, result);
29662960
}
29672961

29682962
@Test
@@ -2974,13 +2968,8 @@ public void testXyseriesMultipleDataFieldsExplain() throws IOException {
29742968
+ " | xyseries state gender in (\"F\", \"M\") avg_balance, cnt",
29752969
TEST_INDEX_BANK));
29762970
var result = explainQueryYaml(query);
2977-
String lower = result.toLowerCase();
2978-
Assert.assertTrue("Expected explain to contain aggregate", lower.contains("aggregate"));
2979-
Assert.assertTrue(
2980-
"Expected explain to contain CASE expression for pivot", lower.contains("case"));
2981-
Assert.assertTrue(
2982-
"Expected explain to contain avg_balance in plan", result.contains("avg_balance"));
2983-
Assert.assertTrue("Expected explain to contain cnt in plan", result.contains("cnt"));
2971+
String expected = loadExpectedPlan("explain_xyseries_multiple_data_fields.yaml");
2972+
assertYamlEqualsIgnoreId(expected, result);
29842973
}
29852974

29862975
@Test
@@ -2992,12 +2981,8 @@ public void testXyseriesWithFormatExplain() throws IOException {
29922981
+ " format=\"$VAL$_$AGG$\" state gender in (\"F\", \"M\") avg_balance",
29932982
TEST_INDEX_BANK));
29942983
var result = explainQueryYaml(query);
2995-
Assert.assertTrue(
2996-
"Expected explain to contain formatted column name F_avg_balance",
2997-
result.contains("F_avg_balance"));
2998-
Assert.assertTrue(
2999-
"Expected explain to contain formatted column name M_avg_balance",
3000-
result.contains("M_avg_balance"));
2984+
String expected = loadExpectedPlan("explain_xyseries_with_format.yaml");
2985+
assertYamlEqualsIgnoreId(expected, result);
30012986
}
30022987

30032988
@Test

0 commit comments

Comments
 (0)