style: ruff format admin, tasks, views, workflow_engine

Author: matteius

django_forms_workflows/admin.py

@@ -151,7 +151,14 @@ class PrefillSourceAdmin(admin.ModelAdmin):
 class FormCategoryAdmin(admin.ModelAdmin):
     """Admin interface for FormCategory grouping primitives."""
 
-    list_display = ["name", "parent", "slug", "order", "is_collapsed_by_default", "icon"]
+    list_display = [
+        "name",
+        "parent",
+        "slug",
+        "order",
+        "is_collapsed_by_default",
+        "icon",
+    ]
     list_editable = ["order", "is_collapsed_by_default"]
     list_filter = ["parent"]
     prepopulated_fields = {"slug": ("name",)}

django_forms_workflows/tasks.py

@@ -101,6 +101,7 @@ def _send_html_email(
 # Notification Batching Helpers
 # ---------------------------------------------------------------------------
 
+
 def _compute_scheduled_for(workflow, submission=None):
     """
     Return a timezone-aware datetime indicating when the next batch for the
@@ -150,9 +151,7 @@ def _at_time(base_dt):
         if date_str:
             try:
                 parsed = datetime.fromisoformat(str(date_str)).date()
-                candidate = timezone.make_aware(
-                    datetime.combine(parsed, raw_time)
-                )
+                candidate = timezone.make_aware(datetime.combine(parsed, raw_time))
                 if candidate > now:
                     return candidate
             except (ValueError, TypeError):
@@ -573,6 +572,7 @@ def send_escalation_notification(task_id: int, to_email: str | None = None) -> N
 # Batched Notification Dispatch
 # ---------------------------------------------------------------------------
 
+
 @shared_task(name="django_forms_workflows.send_batched_notifications")
 def send_batched_notifications() -> str:
     """
@@ -600,7 +600,11 @@ def send_batched_notifications() -> str:
         groups[key].append(pn)
 
     sent_count = 0
-    for (recipient_email, notification_type, _workflow_id), notifications in groups.items():
+    for (
+        recipient_email,
+        notification_type,
+        _workflow_id,
+    ), notifications in groups.items():
         try:
             if notification_type == "submission_received":
                 _dispatch_submission_digest(recipient_email, notifications)

django_forms_workflows/views.py

@@ -51,8 +51,7 @@ def _get_accessible_category_pks(user):
     cat_by_pk = {cat.pk: cat for cat in all_cats}
     # Map each category to its set of required group IDs
     cat_groups = {
-        cat.pk: set(cat.allowed_groups.values_list("id", flat=True))
-        for cat in all_cats
+        cat.pk: set(cat.allowed_groups.values_list("id", flat=True)) for cat in all_cats
     }
 
     _cache = {}  # pk -> bool
@@ -109,7 +108,7 @@ def _build_grouped_forms(forms):
         "name",
     ).select_related("category")
 
-    forms_by_cat = {}   # cat_pk -> [FormDefinition]
+    forms_by_cat = {}  # cat_pk -> [FormDefinition]
     uncategorised = []
 
     for form in ordered:
@@ -123,10 +122,9 @@ def _build_grouped_forms(forms):
 
     # ---- 2. Load all categories and build parent → children map --------
     all_cats = {
-        cat.pk: cat
-        for cat in FormCategory.objects.all().order_by("order", "name")
+        cat.pk: cat for cat in FormCategory.objects.all().order_by("order", "name")
     }
-    children_by_parent = {}   # parent_pk | None -> [FormCategory]
+    children_by_parent = {}  # parent_pk | None -> [FormCategory]
     for cat in all_cats.values():
         children_by_parent.setdefault(cat.parent_id, []).append(cat)
 
@@ -1129,9 +1127,7 @@ def submission_pdf(request, submission_id):
         submission.submitter == request.user
         or request.user.is_superuser
         or user_can_approve(request.user, submission)
-        or request.user.groups.filter(
-            id__in=form_def.admin_groups.all()
-        ).exists()
+        or request.user.groups.filter(id__in=form_def.admin_groups.all()).exists()
     )
     if not can_view:
         return HttpResponseForbidden(

django_forms_workflows/workflow_engine.py

@@ -51,15 +51,21 @@
 
 def _notify_submission_created(submission: FormSubmission) -> None:
     workflow = getattr(submission.form_definition, "workflow", None)
-    cadence = getattr(workflow, "notification_cadence", "immediate") if workflow else "immediate"
+    cadence = (
+        getattr(workflow, "notification_cadence", "immediate")
+        if workflow
+        else "immediate"
+    )
 
     if cadence != "immediate" and workflow is not None:
         try:
             from .tasks import _queue_submission_notifications
 
             _queue_submission_notifications(submission, workflow)
         except Exception:
-            logger.warning("Failed to queue batched submission notification; falling back to immediate")
+            logger.warning(
+                "Failed to queue batched submission notification; falling back to immediate"
+            )
             _notify_submission_created_immediate(submission)
         return
 
@@ -77,15 +83,21 @@ def _notify_submission_created_immediate(submission: FormSubmission) -> None:
 
 def _notify_task_request(task: ApprovalTask) -> None:
     workflow = getattr(task.submission.form_definition, "workflow", None)
-    cadence = getattr(workflow, "notification_cadence", "immediate") if workflow else "immediate"
+    cadence = (
+        getattr(workflow, "notification_cadence", "immediate")
+        if workflow
+        else "immediate"
+    )
 
     if cadence != "immediate" and workflow is not None:
         try:
             from .tasks import _queue_approval_request_notifications
 
             _queue_approval_request_notifications(task, workflow)
         except Exception:
-            logger.warning("Failed to queue batched approval request; falling back to immediate")
+            logger.warning(
+                "Failed to queue batched approval request; falling back to immediate"
+            )
             _notify_task_request_immediate(task)
         return