diff --git a/cmd/downloads/config/downloads_config_test.go b/cmd/downloads/config/downloads_config_test.go index 0c8db247912..214f8b4da36 100644 --- a/cmd/downloads/config/downloads_config_test.go +++ b/cmd/downloads/config/downloads_config_test.go @@ -313,14 +313,18 @@ func TestNewDownloadsServerConfig_CleansOldRandomTempDirs(t *testing.T) { }) oldDirs := []string{ + defaultArtifactsDir, "/tmp/artifacts1234test", "/tmp/artifacts5678test", } + leftover := "leftover" for _, d := range oldDirs { if err := os.MkdirAll(d, 0755); err != nil { t.Fatalf("failed to create old temp dir %s: %v", d, err) } - os.WriteFile(filepath.Join(d, "leftover"), []byte("data"), 0644) + if err := os.WriteFile(filepath.Join(d, leftover), []byte("data"), 0644); err != nil { + t.Fatalf("failed to write leftover file in %s: %v", d, err) + } } srcDir := t.TempDir() @@ -335,6 +339,16 @@ func TestNewDownloadsServerConfig_CleansOldRandomTempDirs(t *testing.T) { } for _, d := range oldDirs { + if d == defaultArtifactsDir { + if _, err := os.Stat(d); err != nil { + t.Errorf("failed to stat artifacts dir: %v", err) + } + f := filepath.Join(d, leftover) + if _, err := os.Stat(f); !os.IsNotExist(err) { + t.Errorf("leftover %s should have been cleaned up, but still exists", f) + } + continue + } if _, err := os.Stat(d); !os.IsNotExist(err) { t.Errorf("old temp dir %s should have been cleaned up, but still exists", d) }