Skip to content

OCPBUGS-83790: change Azure workload identity webhook FailurePolicy from Fail to Ignore #8288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Apr 30, 2026
Merged

OCPBUGS-83790: change Azure workload identity webhook FailurePolicy from Fail to Ignore #8288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...hostedclusterconfigoperator/controllers/resources/azure_workload_identity_webhook_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ func TestReconcileAzureIdentityWebhook(t *testing.T) {
wh := webhook.Webhooks[0]
g.Expect(wh.Name).To(Equal("pod-identity-webhook.azure.mutate.io"))
g.Expect(wh.AdmissionReviewVersions).To(Equal([]string{"v1", "v1beta1"}))
g.Expect(*wh.FailurePolicy).To(Equal(admissionregistrationv1.Fail))
g.Expect(*wh.FailurePolicy).To(Equal(admissionregistrationv1.Ignore))
g.Expect(*wh.MatchPolicy).To(Equal(admissionregistrationv1.Equivalent))
g.Expect(*wh.ReinvocationPolicy).To(Equal(admissionregistrationv1.IfNeededReinvocationPolicy))
g.Expect(*wh.SideEffects).To(Equal(admissionregistrationv1.SideEffectClassNone))
Expand Down
4 changes: 2 additions & 2 deletions control-plane-operator/hostedclusterconfigoperator/controllers/resources/resources.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2594,7 +2594,7 @@ func (r *reconciler) reconcileAzureIdentityWebhook(ctx context.Context) []error
errs = append(errs, fmt.Errorf("failed to reconcile %T %s: %w", clusterRoleBinding, clusterRoleBinding.Name, err))
}

failFailurePolicy := admissionregistrationv1.Fail
ignoreFailurePolicy := admissionregistrationv1.Ignore
sideEffectsNone := admissionregistrationv1.SideEffectClassNone
matchEquivalent := admissionregistrationv1.Equivalent
reinvocationIfNeeded := admissionregistrationv1.IfNeededReinvocationPolicy
Expand All @@ -2607,7 +2607,7 @@ func (r *reconciler) reconcileAzureIdentityWebhook(ctx context.Context) []error
CABundle: []byte(r.rootCA),
URL: ptr.To("https://127.0.0.1:9443/mutate-v1-pod"),
},
FailurePolicy: &failFailurePolicy,
FailurePolicy: &ignoreFailurePolicy,
MatchPolicy: &matchEquivalent,
ReinvocationPolicy: &reinvocationIfNeeded,
ObjectSelector: &metav1.LabelSelector{
Expand Down
Loading