Skip to content

OCPBUGS-86573: [release-4.20] add CP pull-secret watches for in-place propagation #8596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
May 28, 2026
Merged

OCPBUGS-86573: [release-4.20] add CP pull-secret watches for in-place propagation #8596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions api/hypershift/v1beta1/hostedcluster_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,10 +611,11 @@ type HostedClusterSpec struct {
// pullSecret is a local reference to a Secret that must have a ".dockerconfigjson" key whose content must be a valid Openshift pull secret JSON.
// If the reference is set but none of the above requirements are met, the HostedCluster will enter a degraded state.
// TODO(alberto): Signal this in a condition.
// This pull secret will be part of every payload generated by the controllers for any NodePool of the HostedCluster
// and it will be injected into the container runtime of all NodePools.
// Changing this value will trigger a rollout for all existing NodePools in the cluster.
// Changing the content of the secret inplace will not trigger a rollout and might result in unpredictable behaviour.
// This pull secret is included in NodePool ignition/bootstrap payloads and applied to the container runtime when nodes provision.
// Changing this value will trigger a rollout for all existing NodePools in the cluster (for both replace and inplace upgrade types).
// Updating the referenced Secret's data in place (without changing this reference) does not trigger that rollout.
// In AWS and Azure NodePools using the Replace upgrade strategy, the Secret's data in place changes
// will still propagate the updated credentials down to the guest cluster and kubelet config.
// +required
// +rollout
// TODO(alberto): have our own local reference type to include our opinions and avoid transparent changes.
Expand Down
9 changes: 5 additions & 4 deletions ...erated.featuregated-crd-manifests/hostedclusters.hypershift.openshift.io/AAA_ungated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4644,10 +4644,11 @@ spec:
description: |-
pullSecret is a local reference to a Secret that must have a ".dockerconfigjson" key whose content must be a valid Openshift pull secret JSON.
If the reference is set but none of the above requirements are met, the HostedCluster will enter a degraded state.
This pull secret will be part of every payload generated by the controllers for any NodePool of the HostedCluster
and it will be injected into the container runtime of all NodePools.
Changing this value will trigger a rollout for all existing NodePools in the cluster.
Changing the content of the secret inplace will not trigger a rollout and might result in unpredictable behaviour.
This pull secret is included in NodePool ignition/bootstrap payloads and applied to the container runtime when nodes provision.
Changing this value will trigger a rollout for all existing NodePools in the cluster (for both replace and inplace upgrade types).
Updating the referenced Secret's data in place (without changing this reference) does not trigger that rollout.
In AWS and Azure NodePools using the Replace upgrade strategy, the Secret's data in place changes
will still propagate the updated credentials down to the guest cluster and kubelet config.
properties:
name:
default: ""
Expand Down
9 changes: 5 additions & 4 deletions ....featuregated-crd-manifests/hostedclusters.hypershift.openshift.io/AutoNodeKarpenter.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4674,10 +4674,11 @@ spec:
description: |-
pullSecret is a local reference to a Secret that must have a ".dockerconfigjson" key whose content must be a valid Openshift pull secret JSON.
If the reference is set but none of the above requirements are met, the HostedCluster will enter a degraded state.
This pull secret will be part of every payload generated by the controllers for any NodePool of the HostedCluster
and it will be injected into the container runtime of all NodePools.
Changing this value will trigger a rollout for all existing NodePools in the cluster.
Changing the content of the secret inplace will not trigger a rollout and might result in unpredictable behaviour.
This pull secret is included in NodePool ignition/bootstrap payloads and applied to the container runtime when nodes provision.
Changing this value will trigger a rollout for all existing NodePools in the cluster (for both replace and inplace upgrade types).
Updating the referenced Secret's data in place (without changing this reference) does not trigger that rollout.
In AWS and Azure NodePools using the Replace upgrade strategy, the Secret's data in place changes
will still propagate the updated credentials down to the guest cluster and kubelet config.
properties:
name:
default: ""
Expand Down
9 changes: 5 additions & 4 deletions ...manifests/hostedclusters.hypershift.openshift.io/ClusterVersionOperatorConfiguration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4647,10 +4647,11 @@ spec:
description: |-
pullSecret is a local reference to a Secret that must have a ".dockerconfigjson" key whose content must be a valid Openshift pull secret JSON.
If the reference is set but none of the above requirements are met, the HostedCluster will enter a degraded state.
This pull secret will be part of every payload generated by the controllers for any NodePool of the HostedCluster
and it will be injected into the container runtime of all NodePools.
Changing this value will trigger a rollout for all existing NodePools in the cluster.
Changing the content of the secret inplace will not trigger a rollout and might result in unpredictable behaviour.
This pull secret is included in NodePool ignition/bootstrap payloads and applied to the container runtime when nodes provision.
Changing this value will trigger a rollout for all existing NodePools in the cluster (for both replace and inplace upgrade types).
Updating the referenced Secret's data in place (without changing this reference) does not trigger that rollout.
In AWS and Azure NodePools using the Replace upgrade strategy, the Secret's data in place changes
will still propagate the updated credentials down to the guest cluster and kubelet config.
properties:
name:
default: ""
Expand Down
9 changes: 5 additions & 4 deletions ...gated-crd-manifests/hostedclusters.hypershift.openshift.io/DynamicResourceAllocation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4648,10 +4648,11 @@ spec:
description: |-
pullSecret is a local reference to a Secret that must have a ".dockerconfigjson" key whose content must be a valid Openshift pull secret JSON.
If the reference is set but none of the above requirements are met, the HostedCluster will enter a degraded state.
This pull secret will be part of every payload generated by the controllers for any NodePool of the HostedCluster
and it will be injected into the container runtime of all NodePools.
Changing this value will trigger a rollout for all existing NodePools in the cluster.
Changing the content of the secret inplace will not trigger a rollout and might result in unpredictable behaviour.
This pull secret is included in NodePool ignition/bootstrap payloads and applied to the container runtime when nodes provision.
Changing this value will trigger a rollout for all existing NodePools in the cluster (for both replace and inplace upgrade types).
Updating the referenced Secret's data in place (without changing this reference) does not trigger that rollout.
In AWS and Azure NodePools using the Replace upgrade strategy, the Secret's data in place changes
will still propagate the updated credentials down to the guest cluster and kubelet config.
properties:
name:
default: ""
Expand Down
9 changes: 5 additions & 4 deletions ...rated.featuregated-crd-manifests/hostedclusters.hypershift.openshift.io/ExternalOIDC.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4963,10 +4963,11 @@ spec:
description: |-
pullSecret is a local reference to a Secret that must have a ".dockerconfigjson" key whose content must be a valid Openshift pull secret JSON.
If the reference is set but none of the above requirements are met, the HostedCluster will enter a degraded state.
This pull secret will be part of every payload generated by the controllers for any NodePool of the HostedCluster
and it will be injected into the container runtime of all NodePools.
Changing this value will trigger a rollout for all existing NodePools in the cluster.
Changing the content of the secret inplace will not trigger a rollout and might result in unpredictable behaviour.
This pull secret is included in NodePool ignition/bootstrap payloads and applied to the container runtime when nodes provision.
Changing this value will trigger a rollout for all existing NodePools in the cluster (for both replace and inplace upgrade types).
Updating the referenced Secret's data in place (without changing this reference) does not trigger that rollout.
In AWS and Azure NodePools using the Replace upgrade strategy, the Secret's data in place changes
will still propagate the updated credentials down to the guest cluster and kubelet config.
properties:
name:
default: ""
Expand Down
9 changes: 5 additions & 4 deletions ...ests/hostedclusters.hypershift.openshift.io/ExternalOIDCWithUIDAndExtraClaimMappings.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5117,10 +5117,11 @@ spec:
description: |-
pullSecret is a local reference to a Secret that must have a ".dockerconfigjson" key whose content must be a valid Openshift pull secret JSON.
If the reference is set but none of the above requirements are met, the HostedCluster will enter a degraded state.
This pull secret will be part of every payload generated by the controllers for any NodePool of the HostedCluster
and it will be injected into the container runtime of all NodePools.
Changing this value will trigger a rollout for all existing NodePools in the cluster.
Changing the content of the secret inplace will not trigger a rollout and might result in unpredictable behaviour.
This pull secret is included in NodePool ignition/bootstrap payloads and applied to the container runtime when nodes provision.
Changing this value will trigger a rollout for all existing NodePools in the cluster (for both replace and inplace upgrade types).
Updating the referenced Secret's data in place (without changing this reference) does not trigger that rollout.
In AWS and Azure NodePools using the Replace upgrade strategy, the Secret's data in place changes
will still propagate the updated credentials down to the guest cluster and kubelet config.
properties:
name:
default: ""
Expand Down
9 changes: 5 additions & 4 deletions ...turegated-crd-manifests/hostedclusters.hypershift.openshift.io/ImageStreamImportMode.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4645,10 +4645,11 @@ spec:
description: |-
pullSecret is a local reference to a Secret that must have a ".dockerconfigjson" key whose content must be a valid Openshift pull secret JSON.
If the reference is set but none of the above requirements are met, the HostedCluster will enter a degraded state.
This pull secret will be part of every payload generated by the controllers for any NodePool of the HostedCluster
and it will be injected into the container runtime of all NodePools.
Changing this value will trigger a rollout for all existing NodePools in the cluster.
Changing the content of the secret inplace will not trigger a rollout and might result in unpredictable behaviour.
This pull secret is included in NodePool ignition/bootstrap payloads and applied to the container runtime when nodes provision.
Changing this value will trigger a rollout for all existing NodePools in the cluster (for both replace and inplace upgrade types).
Updating the referenced Secret's data in place (without changing this reference) does not trigger that rollout.
In AWS and Azure NodePools using the Replace upgrade strategy, the Secret's data in place changes
will still propagate the updated credentials down to the guest cluster and kubelet config.
properties:
name:
default: ""
Expand Down
9 changes: 5 additions & 4 deletions ...turegated-crd-manifests/hostedclusters.hypershift.openshift.io/KMSEncryptionProvider.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4703,10 +4703,11 @@ spec:
description: |-
pullSecret is a local reference to a Secret that must have a ".dockerconfigjson" key whose content must be a valid Openshift pull secret JSON.
If the reference is set but none of the above requirements are met, the HostedCluster will enter a degraded state.
This pull secret will be part of every payload generated by the controllers for any NodePool of the HostedCluster
and it will be injected into the container runtime of all NodePools.
Changing this value will trigger a rollout for all existing NodePools in the cluster.
Changing the content of the secret inplace will not trigger a rollout and might result in unpredictable behaviour.
This pull secret is included in NodePool ignition/bootstrap payloads and applied to the container runtime when nodes provision.
Changing this value will trigger a rollout for all existing NodePools in the cluster (for both replace and inplace upgrade types).
Updating the referenced Secret's data in place (without changing this reference) does not trigger that rollout.
In AWS and Azure NodePools using the Replace upgrade strategy, the Secret's data in place changes
will still propagate the updated credentials down to the guest cluster and kubelet config.
properties:
name:
default: ""
Expand Down
9 changes: 5 additions & 4 deletions ...egated-crd-manifests/hostedclusters.hypershift.openshift.io/NetworkDiagnosticsConfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4779,10 +4779,11 @@ spec:
description: |-
pullSecret is a local reference to a Secret that must have a ".dockerconfigjson" key whose content must be a valid Openshift pull secret JSON.
If the reference is set but none of the above requirements are met, the HostedCluster will enter a degraded state.
This pull secret will be part of every payload generated by the controllers for any NodePool of the HostedCluster
and it will be injected into the container runtime of all NodePools.
Changing this value will trigger a rollout for all existing NodePools in the cluster.
Changing the content of the secret inplace will not trigger a rollout and might result in unpredictable behaviour.
This pull secret is included in NodePool ignition/bootstrap payloads and applied to the container runtime when nodes provision.
Changing this value will trigger a rollout for all existing NodePools in the cluster (for both replace and inplace upgrade types).
Updating the referenced Secret's data in place (without changing this reference) does not trigger that rollout.
In AWS and Azure NodePools using the Replace upgrade strategy, the Secret's data in place changes
will still propagate the updated credentials down to the guest cluster and kubelet config.
properties:
name:
default: ""
Expand Down
9 changes: 5 additions & 4 deletions ...enerated.featuregated-crd-manifests/hostedclusters.hypershift.openshift.io/OpenStack.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5177,10 +5177,11 @@ spec:
description: |-
pullSecret is a local reference to a Secret that must have a ".dockerconfigjson" key whose content must be a valid Openshift pull secret JSON.
If the reference is set but none of the above requirements are met, the HostedCluster will enter a degraded state.
This pull secret will be part of every payload generated by the controllers for any NodePool of the HostedCluster
and it will be injected into the container runtime of all NodePools.
Changing this value will trigger a rollout for all existing NodePools in the cluster.
Changing the content of the secret inplace will not trigger a rollout and might result in unpredictable behaviour.
This pull secret is included in NodePool ignition/bootstrap payloads and applied to the container runtime when nodes provision.
Changing this value will trigger a rollout for all existing NodePools in the cluster (for both replace and inplace upgrade types).
Updating the referenced Secret's data in place (without changing this reference) does not trigger that rollout.
In AWS and Azure NodePools using the Replace upgrade strategy, the Secret's data in place changes
will still propagate the updated credentials down to the guest cluster and kubelet config.
properties:
name:
default: ""
Expand Down
9 changes: 5 additions & 4 deletions ...ts/hypershift-operator/zz_generated.crd-manifests/hostedclusters-CustomNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6004,10 +6004,11 @@ spec:
description: |-
pullSecret is a local reference to a Secret that must have a ".dockerconfigjson" key whose content must be a valid Openshift pull secret JSON.
If the reference is set but none of the above requirements are met, the HostedCluster will enter a degraded state.
This pull secret will be part of every payload generated by the controllers for any NodePool of the HostedCluster
and it will be injected into the container runtime of all NodePools.
Changing this value will trigger a rollout for all existing NodePools in the cluster.
Changing the content of the secret inplace will not trigger a rollout and might result in unpredictable behaviour.
This pull secret is included in NodePool ignition/bootstrap payloads and applied to the container runtime when nodes provision.
Changing this value will trigger a rollout for all existing NodePools in the cluster (for both replace and inplace upgrade types).
Updating the referenced Secret's data in place (without changing this reference) does not trigger that rollout.
In AWS and Azure NodePools using the Replace upgrade strategy, the Secret's data in place changes
will still propagate the updated credentials down to the guest cluster and kubelet config.
properties:
name:
default: ""
Expand Down
9 changes: 5 additions & 4 deletions ...all/assets/hypershift-operator/zz_generated.crd-manifests/hostedclusters-Default.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5306,10 +5306,11 @@ spec:
description: |-
pullSecret is a local reference to a Secret that must have a ".dockerconfigjson" key whose content must be a valid Openshift pull secret JSON.
If the reference is set but none of the above requirements are met, the HostedCluster will enter a degraded state.
This pull secret will be part of every payload generated by the controllers for any NodePool of the HostedCluster
and it will be injected into the container runtime of all NodePools.
Changing this value will trigger a rollout for all existing NodePools in the cluster.
Changing the content of the secret inplace will not trigger a rollout and might result in unpredictable behaviour.
This pull secret is included in NodePool ignition/bootstrap payloads and applied to the container runtime when nodes provision.
Changing this value will trigger a rollout for all existing NodePools in the cluster (for both replace and inplace upgrade types).
Updating the referenced Secret's data in place (without changing this reference) does not trigger that rollout.
In AWS and Azure NodePools using the Replace upgrade strategy, the Secret's data in place changes
will still propagate the updated credentials down to the guest cluster and kubelet config.
properties:
name:
default: ""
Expand Down
Loading