From d82b9b1987bab666841099cec60d42303a57a5f1 Mon Sep 17 00:00:00 2001
From: spideystreet <dhicham.pro@gmail.com>
Date: Wed, 29 Apr 2026 18:03:50 +0200
Subject: [PATCH 1/2] fix(ci): set DAGSTER_* env for Dagster smoke test on
 GitHub Actions

dagster.yaml uses env-based DAGSTER_STORAGE_DIR/DAGSTER_LOGS_DIR; the runner
otherwise fails instance config loading and never reaches Serving dagster-webserver.

Made-with: Cursor
---
 .github/workflows/quality-checks.yml | 9 ++++++++-
 .gitignore                           | 3 +++
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/quality-checks.yml b/.github/workflows/quality-checks.yml
index be33950..0e0fd24 100644
--- a/.github/workflows/quality-checks.yml
+++ b/.github/workflows/quality-checks.yml
@@ -42,7 +42,14 @@ jobs:
         run: uv run pytest -m api --no-cov
 
       - name: Dagster startup smoke test
-        run: uv run pytest -m integration -k test_dagster_startup --no-cov
+        env:
+          # Match dagster.yaml (env-based storage/logs); runner has no Docker .env defaults.
+          DAGSTER_HOME: ${{ github.workspace }}
+          DAGSTER_STORAGE_DIR: ${{ github.workspace }}/tmp_dagster/storage
+          DAGSTER_LOGS_DIR: ${{ github.workspace }}/tmp_dagster/logs
+        run: |
+          mkdir -p "$DAGSTER_STORAGE_DIR" "$DAGSTER_LOGS_DIR"
+          uv run pytest -m integration -k test_dagster_startup --no-cov
 
   dbt-check:
     runs-on: ubuntu-latest
diff --git a/.gitignore b/.gitignore
index 316f343..60a6334 100644
--- a/.gitignore
+++ b/.gitignore
@@ -79,6 +79,9 @@ PR.md
 PR.txt
 TODO.md
 
+# CI ephemeral Dagster dirs (quality-checks sets DAGSTER_* under repo root)
+tmp_dagster/
+
 # Local
 .actrc
 .mcp.json

From 40a335a39c06ed243878ce6ddc87cdf93105e3ec Mon Sep 17 00:00:00 2001
From: spideystreet <dhicham.pro@gmail.com>
Date: Wed, 29 Apr 2026 18:04:22 +0200
Subject: [PATCH 2/2] ci: run Publish develop checks on PRs to develop

Made-with: Cursor
---
 .github/workflows/publish-develop.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/publish-develop.yml b/.github/workflows/publish-develop.yml
index 26719d8..809202f 100644
--- a/.github/workflows/publish-develop.yml
+++ b/.github/workflows/publish-develop.yml
@@ -2,7 +2,7 @@ name: Publish develop
 
 on:
   pull_request:
-    branches: [ main, staging ]
+    branches: [ develop, main, staging ]
   push:
     branches:
       - staging