From ff20222e0d16d342c7991b41ec2daeba89c59084 Mon Sep 17 00:00:00 2001 From: Lucas Alvares Gomes Date: Fri, 10 Jul 2026 11:44:43 +0100 Subject: [PATCH] Enable gosec linter Enable gosec linter and suppress false positives: G101 on k8s resource names constants. Also, exclude test files and the test/ directory from gosec. Signed-off-by: Lucas Alvares Gomes --- .golangci.yml | 7 +++++++ internal/controller/constants.go | 6 +++--- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index 9ee1fee..a67edde 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -8,6 +8,7 @@ linters: - errcheck - ginkgolinter - goconst + - gosec - gocyclo - govet - ineffassign @@ -34,6 +35,12 @@ linters: - dupl - lll path: internal/* + - linters: + - gosec + path: _test\.go + - linters: + - gosec + path: ^test/ paths: - third_party$ - builtin$ diff --git a/internal/controller/constants.go b/internal/controller/constants.go index 088d7ff..bf4dbee 100644 --- a/internal/controller/constants.go +++ b/internal/controller/constants.go @@ -36,10 +36,10 @@ const ( OpenStackLightspeedDefaultProvider = "openstack-lightspeed-provider" OpenStackLightspeedVectorDBPath = "/rag/vector_db/os_product_docs" - ServingCertSecretAnnotationKey = "service.beta.openshift.io/serving-cert-secret-name" + ServingCertSecretAnnotationKey = "service.beta.openshift.io/serving-cert-secret-name" // #nosec G101 -- annotation key, not a credential // Monitoring - MetricsReaderServiceAccountTokenSecretName = "metrics-reader-token" + MetricsReaderServiceAccountTokenSecretName = "metrics-reader-token" // #nosec G101 -- Kubernetes Secret resource name, not a credential MetricsReaderServiceAccountName = "lightspeed-operator-metrics-reader" // Postgres @@ -284,7 +284,7 @@ const ( // by the OpenShift service-ca operator when the lightspeed-app-server Service is // annotated with service.beta.openshift.io/serving-cert-secret-name. Contains // tls.crt and tls.key used by the lightspeed-service-api container to serve HTTPS. - OpenStackLightspeedCertsSecretName = "lightspeed-tls" + OpenStackLightspeedCertsSecretName = "lightspeed-tls" // #nosec G101 -- Kubernetes Secret resource name, not a credential // PostgresCertsSecretName is the name of the Secret auto-provisioned by the // OpenShift service-ca operator when the lightspeed-postgres-server Service is