Skip to content

Set RHOSO Lightspeed specific system prompt#66

Merged
openshift-merge-bot[bot] merged 4 commits into
openstack-lightspeed:mainfrom
lpiwowar:lpiwowar/rhoso-system-prompt
Jan 22, 2026
Merged

Set RHOSO Lightspeed specific system prompt#66
openshift-merge-bot[bot] merged 4 commits into
openstack-lightspeed:mainfrom
lpiwowar:lpiwowar/rhoso-system-prompt

Conversation

@lpiwowar

@lpiwowar lpiwowar commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

When RHOSO Lightspeed operator deployes OLS operator it uses the default OLS system prompt which leads to more OpenShift focused responses from RHOSO Lightspeed.

This commit utilizies the querySystemPrompt parameter in OLSConfig to configure OLS with RHOSO specific system prompt.

Depends-On: openshift/lightspeed-operator#1211

@openshift-ci

openshift-ci Bot commented Jan 7, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@lpiwowar

Copy link
Copy Markdown
Contributor Author

/test all

@lpiwowar lpiwowar marked this pull request as ready for review January 14, 2026 11:57
@openshift-ci openshift-ci Bot requested review from Akrog and umago January 14, 2026 11:57
@lpiwowar

lpiwowar commented Jan 14, 2026

Copy link
Copy Markdown
Contributor Author

Right now this will have no effect because the version of OLS operator that is currently published does not contain this change [1] yet. The querySystemPrompt parameter is present in the OLSConfig CR, but does not work for the non-lcore backend. Once [1] is released as part of the next OLS operator version, the change our operator makes should take effect.

[1] github.com/openshift/lightspeed-operator/pull/1211

Comment thread internal/controller/system_prompt.txt Outdated
Comment thread internal/controller/system_prompt.txt Outdated
@lpiwowar lpiwowar force-pushed the lpiwowar/rhoso-system-prompt branch from 452a30d to f5da95b Compare January 15, 2026 12:31

@umago umago left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci

openshift-ci Bot commented Jan 16, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lpiwowar, umago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@umago

umago commented Jan 16, 2026

Copy link
Copy Markdown
Contributor

/lgtm cancel

@openshift-ci openshift-ci Bot removed the lgtm label Jan 16, 2026
@umago

umago commented Jan 16, 2026

Copy link
Copy Markdown
Contributor

I think @Akrog should also take a look at it, but it l.g.t.m :-)

lpiwowar and others added 3 commits January 20, 2026 17:09
When RHOSO Lightspeed operator deployes OLS operator it uses the default
OLS system prompt which leads to more OpenShift focused responses from
RHOSO Lightspeed.

This commit utilizies the querySystemPrompt parameter in OLSConfig to
configure OLS with RHOSO specific system prompt.

Depends-On: openshift/lightspeed-operator#1211
Co-Authored-By: Gorka Eguileor <geguileo@redhat.com>
Fix punctuation and remove duplicate content:

1. Move comma outside quotation marks in role description.

2. Remove redundant persona statement from behavioral directives.
Add directive to system prompt ensuring RHOSO Lightspeed only
references Red Hat products (RHEL, Fedora, CoreOS, CentOS) and
excludes Ubuntu/Debian mentions.
@lpiwowar lpiwowar force-pushed the lpiwowar/rhoso-system-prompt branch from fd58b73 to 3cf1042 Compare January 20, 2026 16:10
@lpiwowar

Copy link
Copy Markdown
Contributor Author

The CI is failing with:

namespace/openshift-lightspeed created
time="2026-01-20T16:17:16Z" level=info msg="Creating a File-Based Catalog of the bundle \"registry.build05.ci.openshift.org/ci-op-gz31yd25/pipeline@sha256:f8a19adf7ad16566c4c5d745c9470aa8d6d2dc817b312aabc7c07d6a5290544b\""
time="2026-01-20T16:17:16Z" level=info msg="Generated a valid File-Based Catalog"
time="2026-01-20T16:18:15Z" level=info msg="Created registry pod: 8a19adf7ad16566c4c5d745c9470aa8d6d2dc817b312aabc7c07d6a5290544b"
time="2026-01-20T16:18:15Z" level=info msg="Created CatalogSource: openstack-lightspeed-operator-catalog"
time="2026-01-20T16:18:16Z" level=info msg="OperatorGroup \"operator-sdk-og\" created"
time="2026-01-20T16:18:16Z" level=info msg="Created Subscription: openstack-lightspeed-operator-v0-0-1-sub"
time="2026-01-20T16:18:55Z" level=fatal msg="Failed to run bundle: install plan is not available for the subscription openstack-lightspeed-operator-v0-0-1-sub: Get \"https://api.oko-04.oooci.ccitredhat.com:6443/apis/operators.coreos.com/v1alpha1/namespaces/openshift-lightspeed/subscriptions/openstack-lightspeed-operator-v0-0-1-sub\": context deadline exceeded\n"
{"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:84","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2026-01-20T16:18:55Z"}
error: failed to execute wrapped command: exit status 1

It looks like it is not related to the PR. Let's retest and see.

@lpiwowar

Copy link
Copy Markdown
Contributor Author

/test openstack-lightspeed-kuttl-4-18

@umago

umago commented Jan 21, 2026

Copy link
Copy Markdown
Contributor

@Akrog, I'm good with the proposed system prompt. Do u want to take a look as well ? I believe the instructions should be similar to what you have tested before

Comment thread internal/controller/system_prompt.txt Outdated
also called OSP 18, although usually OSP refers to previous releases deployed
using TripleO/Director.

The OpenStack control plane runs on OpenShift, while compute nodes run in

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Maybe we should mention that OpenShift uses CoreOS as the operating system and EDPM nodes run RHEL.

Specify that OpenShift uses CoreOS as the operating system and EDPM
nodes run RHEL to provide clearer context in the system prompt.
@lpiwowar lpiwowar force-pushed the lpiwowar/rhoso-system-prompt branch from 4cdb0e6 to 68ce6d5 Compare January 22, 2026 11:54
@umago

umago commented Jan 22, 2026

Copy link
Copy Markdown
Contributor

Latest changes looks good!

@umago

umago commented Jan 22, 2026

Copy link
Copy Markdown
Contributor

@lpiwowar do u want to squash the commits or we do it at merge time ?

@lpiwowar

Copy link
Copy Markdown
Contributor Author

@umago I think keeping the commits is ok as they are not "ugly" IMO and explain the development of the original system prompt. I would keep them unless you think otherwise:)

@umago

umago commented Jan 22, 2026

Copy link
Copy Markdown
Contributor

@lpiwowar ok then! Sounds good

@umago

umago commented Jan 22, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jan 22, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit b6cc1dc into openstack-lightspeed:main Jan 22, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants