Set RHOSO Lightspeed specific system prompt#66
Conversation
|
Skipping CI for Draft Pull Request. |
da5844c to
c01f994
Compare
|
/test all |
|
Right now this will have no effect because the version of OLS operator that is currently published does not contain this change [1] yet. The [1] github.com/openshift/lightspeed-operator/pull/1211 |
452a30d to
f5da95b
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lpiwowar, umago The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm cancel |
|
I think @Akrog should also take a look at it, but it l.g.t.m :-) |
When RHOSO Lightspeed operator deployes OLS operator it uses the default OLS system prompt which leads to more OpenShift focused responses from RHOSO Lightspeed. This commit utilizies the querySystemPrompt parameter in OLSConfig to configure OLS with RHOSO specific system prompt. Depends-On: openshift/lightspeed-operator#1211 Co-Authored-By: Gorka Eguileor <geguileo@redhat.com>
Fix punctuation and remove duplicate content: 1. Move comma outside quotation marks in role description. 2. Remove redundant persona statement from behavioral directives.
Add directive to system prompt ensuring RHOSO Lightspeed only references Red Hat products (RHEL, Fedora, CoreOS, CentOS) and excludes Ubuntu/Debian mentions.
fd58b73 to
3cf1042
Compare
|
The CI is failing with: It looks like it is not related to the PR. Let's retest and see. |
|
/test openstack-lightspeed-kuttl-4-18 |
|
@Akrog, I'm good with the proposed system prompt. Do u want to take a look as well ? I believe the instructions should be similar to what you have tested before |
| also called OSP 18, although usually OSP refers to previous releases deployed | ||
| using TripleO/Director. | ||
|
|
||
| The OpenStack control plane runs on OpenShift, while compute nodes run in |
There was a problem hiding this comment.
nit: Maybe we should mention that OpenShift uses CoreOS as the operating system and EDPM nodes run RHEL.
Specify that OpenShift uses CoreOS as the operating system and EDPM nodes run RHEL to provide clearer context in the system prompt.
4cdb0e6 to
68ce6d5
Compare
|
Latest changes looks good! |
|
@lpiwowar do u want to squash the commits or we do it at merge time ? |
|
@umago I think keeping the commits is ok as they are not "ugly" IMO and explain the development of the original system prompt. I would keep them unless you think otherwise:) |
|
@lpiwowar ok then! Sounds good |
|
/lgtm |
b6cc1dc
into
openstack-lightspeed:main
When RHOSO Lightspeed operator deployes OLS operator it uses the default OLS system prompt which leads to more OpenShift focused responses from RHOSO Lightspeed.
This commit utilizies the querySystemPrompt parameter in OLSConfig to configure OLS with RHOSO specific system prompt.
Depends-On: openshift/lightspeed-operator#1211