Adapt the operator to recent OLS release#79
Merged
openshift-merge-bot[bot] merged 3 commits intoFeb 4, 2026
Merged
Conversation
Replace the Reconciled condition check with overallStatus: Ready in the OpenStackLightspeed instance assertion. This aligns the test with the updated status section (recent OLS operator release).
Simplify IsOLSConfigReady by checking the new overallStatus field instead of iterating over individual conditions. This field is set to Ready when the OLS deployment completes successfully.
|
Skipping CI for Draft Pull Request. |
Contributor
Author
|
/test all |
Contributor
Author
|
/test openstack-lightspeed-kuttl-4-18 |
After calling Delete(), the function now verifies that the OLSConfig is actually deleted by checking if GetOLSConfig returns NotFound. This prevents a race condition where RemoveOLSConfig would return true while the resource was still in Terminating state (due to the lightspeed-operator's finalizer), causing the controller to proceed with uninstalling the OLS operator before it could remove its own finalizer. This commit introduced the finalizer on the OLS side [1]. [1] openshift/lightspeed-operator@5571e58
Contributor
Author
|
/retest-required |
lpiwowar
changed the title
umago
approved these changes
Feb 4, 2026
umago
left a comment
umago
left a comment
Contributor
There was a problem hiding this comment.
Looks good! I like that it's much simpler now, just looking at the overallStatus field to know when OLSConfig is ready.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lpiwowar, umago The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit 18c5044
into
openstack-lightspeed:main
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent
1.0.9release of the OLS operator requires the following changes on our side in order for us to be still compatible:1. Use overallStatus field from OLSConfig
Simplify
IsOLSConfigReadyby checking the newoverallStatusfield instead of iterating over individual conditions. This field is set to Ready when the OLS deployment completes successfully [1].[1] https://github.com/openshift/lightspeed-operator/pull/1190/changes#diff-77e6d7fe1846c7ad02af9efceb28f7be71b1335993f6d36664418fb4c3bec33bR65
2. Fix RemoveOLSConfig to wait for actual deletion
After calling Delete(), the function now verifies that the OLSConfig is actually deleted by checking if GetOLSConfig returns NotFound.
This prevents a race condition where RemoveOLSConfig would return true while the resource was still in Terminating state (due to the lightspeed-operator's finalizer), causing the controller to proceed with uninstalling the OLS operator before it could remove its own finalizer.
This commit introduced the finalizer on the OLS side [1].
[1] openshift/lightspeed-operator@5571e58
3. Update KUTTL assertion to check overallStatus
Replace the Reconciled condition check with overallStatus: Ready in the OpenStackLightspeed instance assertion. This aligns the test with the updated status section (recent OLS operator release).