Allow OPENSHIFT_LIGHTSPEED_OPERATOR_VERSION override#80
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lpiwowar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add support for setting OPENSHIFT_LIGHTSPEED_OPERATOR_VERSION variable during 'make bundle' to override the default 'latest' value.
lpiwowar
force-pushed
the
lpiwowar/openshift-lightspeed-version
branch
from
07ab62f to
9460455
Compare
|
/test all |
|
Thanks for the patch! It /lgtm |
|
/lgtm |
| cd config/manager && $(KUSTOMIZE) edit add patch --kind Deployment --name controller-manager --patch "[{\"op\": \"replace\", \"path\": \"/spec/template/spec/containers/0/env/0/value\", \"value\": \"$(OPENSHIFT_LIGHTSPEED_OPERATOR_VERSION)\"}]" | ||
| $(KUSTOMIZE) build config/manifests | $(OPERATOR_SDK) generate bundle $(BUNDLE_GEN_FLAGS) | ||
| $(OPERATOR_SDK) bundle validate ./bundle | ||
| cd config/manager && $(KUSTOMIZE) edit remove patch --kind Deployment --name controller-manager --patch "[{\"op\": \"replace\", \"path\": \"/spec/template/spec/containers/0/env/0/value\", \"value\": \"$(OPENSHIFT_LIGHTSPEED_OPERATOR_VERSION)\"}]" |
There was a problem hiding this comment.
I think we should remove this line, that way the files we leave are the ones that have been validated.
That's the pattern used in the other operators https://github.com/openstack-k8s-operators/openstack-operator/blob/3c0eba8e939b80f2cb9331e874080a0c8208d73e/Makefile#L402
openshift-merge-bot
Bot
merged commit 2e170ee
into
openstack-lightspeed:main
Retain patch modifications in config/manager/kustomization.yaml instead of removing them after bundle generation. This aligns with the pattern used in the openstack-k8s-operators namespace. The Makefile no longer removes the deployment patch, keeping the kustomization file consistent with the generated bundle. Implements request in this comment [1]. [1] openstack-lightspeed#80 (comment)
3 participants
Add support for setting OPENSHIFT_LIGHTSPEED_OPERATOR_VERSION variable during 'make bundle' to override the default 'latest' value.