Skip to content

Add the disconnected annotation#83

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-lightspeed:mainfrom
umago:annotate-disconnected
Feb 19, 2026
Merged

Add the disconnected annotation#83
openshift-merge-bot[bot] merged 1 commit into
openstack-lightspeed:mainfrom
umago:annotate-disconnected

Conversation

@umago

@umago umago commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

The commit 0764340 added support for airgapped (disconnect) environments. This patch just adds the annotation indicates that the Operator works in a disconnected environment.

Operators such as the "openstack" one already uses this annotation [0] and it is suggested by [1] so it can be filtered in OperatorHub by this infrastructure feature.

[0] openstack-k8s-operators/openstack-operator@6b99f5b
[1] https://docs.redhat.com/en/documentation/openshift_container_platform/4.18/html/operators/developing-operators

@openshift-ci openshift-ci Bot requested review from Akrog and lpiwowar February 17, 2026 15:09
@openshift-ci

openshift-ci Bot commented Feb 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: umago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@umago

umago commented Feb 17, 2026

Copy link
Copy Markdown
Contributor Author

@dprince quick one

@lpiwowar lpiwowar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my point of view:). I'll wait for comment from Dan P.

The commit 0764340 added support for
airgapped (disconnect) environments. This patch just adds the annotation
indicates that the Operator works in a disconnected environment.

Operators such as the "openstack" one already uses this annotation [0]
and it is suggested by [1] so it can be filtered in OperatorHub by this
infrastructure feature.

[0] openstack-k8s-operators/openstack-operator@6b99f5b
[1] https://docs.redhat.com/en/documentation/openshift_container_platform/4.18/html/operators/developing-operators

Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com>
@umago umago force-pushed the annotate-disconnected branch from f9854e2 to 2413d71 Compare February 19, 2026 09:37
@lpiwowar

Copy link
Copy Markdown
Contributor

/lgtm

Let's merge this because we need this annotation for nice integration into the community-operators catalog. If you think there is something wrong @dprince about this let us know please:).

@openshift-ci openshift-ci Bot added the lgtm label Feb 19, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 4d5d3ec into openstack-lightspeed:main Feb 19, 2026
7 checks passed
@umago umago deleted the annotate-disconnected branch March 10, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants