Skip to content

Remove duplicate "cleanup" entry #12

@lpiwowar

Description

@lpiwowar

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Remove duplicate "cleanup" entry.

The REJECT_COMMANDS set contains "cleanup" twice (once around line 43 and again at line 46). While Python sets automatically deduplicate at runtime, the duplicate entry is unnecessary and flagged by static analysis.

🧹 Proposed fix
     "migrate",
     "resize",
     "cleanup",
-    "cleanup",
     "shelve",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

    "migrate",
    "resize",
    "cleanup",
🧰 Tools
🪛 Ruff (0.15.14)

[warning] 46-46: Sets should not contain duplicate item "cleanup"

Remove duplicate item

(B033)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@scripts/allow-deny-list.py` around lines 43 - 46, Remove the duplicate
"cleanup" entry from the REJECT_COMMANDS collection: find the REJECT_COMMANDS
definition (variable name REJECT_COMMANDS) and delete the redundant "cleanup"
element so it only appears once; no behavior change needed since Python
deduplicates sets, but this removes the static-analysis warning and cleans up
the list.

Originally posted by @coderabbitai[bot] in #11 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions