From ff6ec8bb2489783a0be6a12e305ee6ff2bef6310 Mon Sep 17 00:00:00 2001
From: Greg Zaitsev <gregz@opentensor.dev>
Date: Fri, 26 Jun 2026 11:41:33 +0300
Subject: [PATCH] Enforce conviction, add test, bump spec

---
 .../subtensor/src/coinbase/run_coinbase.rs    |  5 +-
 pallets/subtensor/src/tests/locks.rs          | 54 +++++++++++++++++++
 runtime/src/lib.rs                            |  2 +-
 3 files changed, 57 insertions(+), 4 deletions(-)

diff --git a/pallets/subtensor/src/coinbase/run_coinbase.rs b/pallets/subtensor/src/coinbase/run_coinbase.rs
index d7c75964b2..84fdac3012 100644
--- a/pallets/subtensor/src/coinbase/run_coinbase.rs
+++ b/pallets/subtensor/src/coinbase/run_coinbase.rs
@@ -411,9 +411,8 @@ impl<T: Config> Pallet<T> {
                 );
                 epochs_run_this_block = epochs_run_this_block.saturating_add(1);
 
-                // Reserved for potential future enhancements.
-                // Ownership update logic based on conviction is currently inactive by design.
-                // Self::change_subnet_owner_if_needed(netuid);
+                // Change subnet owner based on conviction.
+                Self::change_subnet_owner_if_needed(netuid);
             } else {
                 // Schedule advances below; execution skipped. Pending emissions accumulate
                 // and will be drained by the next successful epoch.
diff --git a/pallets/subtensor/src/tests/locks.rs b/pallets/subtensor/src/tests/locks.rs
index 91b48b7881..17e45595cd 100644
--- a/pallets/subtensor/src/tests/locks.rs
+++ b/pallets/subtensor/src/tests/locks.rs
@@ -2951,6 +2951,60 @@ fn test_change_subnet_owner_if_needed_reassigns_to_subnet_king() {
     });
 }
 
+#[test]
+fn test_run_coinbase_reassigns_subnet_owner_by_conviction_on_epoch() {
+    new_test_ext(1).execute_with(|| {
+        let old_owner_coldkey = U256::from(1);
+        let old_owner_hotkey = U256::from(2);
+        let netuid = setup_subnet_with_stake(old_owner_coldkey, old_owner_hotkey, 100_000_000_000);
+        SubnetOwner::<Test>::insert(netuid, old_owner_coldkey);
+        SubnetOwnerHotkey::<Test>::insert(netuid, old_owner_hotkey);
+
+        let new_owner_coldkey = U256::from(5);
+        let king_hotkey = U256::from(6);
+        assert_ok!(SubtensorModule::create_account_if_non_existent(
+            &new_owner_coldkey,
+            &king_hotkey
+        ));
+
+        let now = crate::staking::lock::ONE_YEAR + 1;
+        System::set_block_number(now);
+        NetworkRegisteredAt::<Test>::insert(netuid, 1);
+        SubnetAlphaOut::<Test>::insert(netuid, AlphaBalance::from(10_000u64));
+        SubtensorModule::set_tempo_unchecked(netuid, 1);
+        LastEpochBlock::<Test>::insert(netuid, now.saturating_sub(1));
+        PendingEpochAt::<Test>::insert(netuid, 0);
+
+        let locked_mass = AlphaBalance::from(1_000u64);
+        Lock::<Test>::insert(
+            (new_owner_coldkey, netuid, king_hotkey),
+            LockState {
+                locked_mass,
+                conviction: U64F64::from_num(1_000),
+                last_update: now,
+            },
+        );
+        HotkeyLock::<Test>::insert(
+            netuid,
+            king_hotkey,
+            LockState {
+                locked_mass,
+                conviction: U64F64::from_num(1_000),
+                last_update: now,
+            },
+        );
+
+        assert_eq!(SubnetOwner::<Test>::get(netuid), old_owner_coldkey);
+        assert_eq!(SubnetOwnerHotkey::<Test>::get(netuid), old_owner_hotkey);
+
+        SubtensorModule::run_coinbase(SubtensorModule::mint_tao(0.into()));
+
+        assert_eq!(SubnetOwner::<Test>::get(netuid), new_owner_coldkey);
+        assert_eq!(SubnetOwnerHotkey::<Test>::get(netuid), king_hotkey);
+        assert_eq!(LastEpochBlock::<Test>::get(netuid), now);
+    });
+}
+
 #[test]
 fn test_change_subnet_owner_rebuilds_old_owner_hotkey_by_lock_mode() {
     new_test_ext(1).execute_with(|| {
diff --git a/runtime/src/lib.rs b/runtime/src/lib.rs
index b4fb481f7f..ac4da43b3b 100644
--- a/runtime/src/lib.rs
+++ b/runtime/src/lib.rs
@@ -234,7 +234,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
     //   `spec_version`, and `authoring_version` are the same between Wasm and native.
     // This value is set to 100 to notify Polkadot-JS App (https://polkadot.js.org/apps) to use
     //   the compatible custom types.
-    spec_version: 423,
+    spec_version: 424,
     impl_version: 1,
     apis: RUNTIME_API_VERSIONS,
     transaction_version: 1,