Mojolicious 9.43 or newer breaks our `list_tree` usage.

[drgrice1]

For Mojolicious 9.42 or before the Mojo::File list_tree method did not include files inside symbolic link directories. A change to Mojolicious 9.43 (that I believe was unintentional, see mojolicious/mojo#2318) makes it so that it does.

This breaks the webwork2 usage rather badly. This method is used to list all files to include in a course archive, and so now everything inside the directories linked to by Contrib and Library will be listed and included in the course archive. There are other places that list_tree is used and it will surely cause problems for those as well.

So if they leave it the way it is, then we are going to have to check all files listed, and exclude the files contained inside a directory that is a symbolic link which would be a real pain.

For now we need to make sure that everyone sticks to versions 9.34 through 9.42 of Mojolicous.

[taniwallach]

If webwork needs a workaround, maybe it would be simpler to locally implement list_tree based on the old code.

[drgrice1]

It seems that the Mojolicious developers heeded my issue after all. They made the list_tree not include the contents of symlink directories, and then added a list_tree with symlinks method that does include those contents. See mojolicious/mojo@cbcf640. That will be in the next release which will be version 9.46. So we will just need to avoid versions 9.43 through 9.45.

[somiaj]

Can check_modules.pl maybe let users know if they have that range of versions?

[somiaj]

Not that is important to us, but isn't list_tree with symlinks just a test to avoid future regressions?

[drgrice1]

You are correct. I didn't look closely.

[drgrice1]

It would be tricky and messy to implement a range of versions to avoid in check_modules.pl in a nice way. It could probably be done though.

[somiaj]

Also the comment they added in the changelog was 4.47 UNRELEASED, so maybe we need to avoid 4.43 through 4.46.

[somiaj]

Assuming no distro actually releases with Mojolicioius in that range, probably not a big deal once 4.47 is on CPAN, and overkill to try to add that check if it is messy.

[drgrice1]

I see that 4.46 is releaseed. So yes, then 4.47.