WeBWorK-2.15-beta#948
Merged
Merged
Conversation
To allow the 1000 byte limit for keys, the OPL_local_statistics was
changed to use ENGINE=MyISAM. That change allowed reducing the
source_file column from varchar(255) to varchar(245), while the
767 bytes key limit of ENGINE=InnoDB as was used by this table and
by OPL_global_statistics.sql (at present) would have limited this to
about 191 characters.
The OPL_problem_user table had 3 keys changed from using 100 characters
each to using only 80 characters each. The same changes were already
made to lib/WeBWorK/DB/Record/PastAnswer.pm for the same reason. Only
the first 245 characters of source_file are used as a key. Finally,
the CHARACTER SET of OPL_problem_user was explicitly changed from ascii
to utf8mb4.
The saved version of OPL_global_statistics.sql needs to be hand modified
as follows, until the GitHub master branch has these changes made. Only
after those changes can the file be loaded into a utf8mb4 database.
utf8 => utf8mb4
255 => 245
ENGINE=InnoDB => ENGINE=MyISAM
=================================
10c10
< /*!40101 SET NAMES utf8mb4 */;
---
> /*!40101 SET NAMES utf8 */;
24c24
< /*!40101 SET character_set_client = utf8mb4 */;
---
> /*!40101 SET character_set_client = utf8 */;
26c26
< `source_file` varchar(245) NOT NULL,
---
> `source_file` varchar(255) NOT NULL,
31c31
< ) ENGINE=MyISAM DEFAULT CHARSET=utf8mb4;
---
> ) ENGINE=InnoDB DEFAULT CHARSET=utf8;
Note: When I tried to include XML::Simple near the start of the first "cpanm install" line, there was an error: Building and testing XMLRPC-Lite-0.717 ... ! Installing XMLRPC::Lite failed. See /root/.cpanm/work/1551887935.125/build.log for details. Retry with --force to force install it. so it was put into a second "cpanm install" line.
…2019_utf8mb4 Tani develop candidate 02 24 2019 utf8mb4
Fix the union toolbar button to show the union, rather than the letter U. It will still put the letter U into the actual webwork answer box. Add a subscript toolbar button. Clean up the appearance of the toolbar a bit.
…le. (Not currently possible in read_whole_file inside the Safe compartment.
…3_10_2019 # Conflicts: # lib/Apache/WeBWorK.pm
Change FileManager to be compatible with UTF-8
implement handlers that notify when a TextBlock gains and loses focus. These handlers are then used to disable the toolbar when a TextBlock is entered, and re-enable the toolbar when a TextBlock is exited. With this we can switch back to using the 'cmd' method of MathQuill rather than the 'typedText' method. The 'cmd' method works better on latex commands. Particularly if there is a selection in the MathField. Remove the subscript toolbar button. At this point it seems there isn't anything in webwork that works with. Finally, remove the charsThatBreakOutOfSupSub and autoSubscriptNumerals options.
When set to zero this can be used with mysql before 5.3 (they cannot handle utf8mb4), when set to 1 OPL scripts will build a utf8mb4 version of the OPL. $ENABLE_UTF8MB4 =1;
Removed localOverrides.conf.dist section on setting ENABLE_UTF8MB4. There was potential for confusion because changing the value in site.conf would not change behavior.
…ocess from dying when htdocs/tmp directory doesn't exist.
…ocess from dying when htdocs/tmp directory doesn't exist. install XMLRPC::Lite from ubuntu source rather than CPAN
…m/mgage/webwork2 into develop_multi_ling_03_14_2019_mb4
…ides.conf in order to over ride the default in default.config The configuration in site.conf is always overridden by the one in default.config
…sql database allows this).
…rom $SITE_URL and REQUEST_URI()
Code to support adding additional CSS files requested by problems
We b wor k 2.15 add tests3 remove cruft
Check for proper action (non-capitalized) in getFile().
intended for use in an LTI course where automatic LTI account creation is not desired, ex. after the end of a semester if new accounts may potentially be added to the LMS. The setting $block_lti_create_user = 1; can be added to the course.conf file.
…dXMLRPC Webwork 2.15 missing fixes to send xmlrpc
…er_setting Add handling for a new LTI setting: $block_lti_create_user
encodeAnswers() and decodeAnswers() which are used to encode/decode the last_answer field in the COURSEID_problem_user table to use JSON instead of Storable::nfreeze() and Storable::thaw() which failed to properly handle UTF-8 data in answers, or many answers with over 127 characters (due to the binary length code appearing to be an invalid UTF-8 character). The decodeAnswers() falls back to the OLD Storable::thaw() based code for backwards compatibility when the value returned from the database does not seem to be a JSON array (currently detected by checking for a leading '[' and a trailing ']') while the Storable::nfreeze() seems to always start with several control characters. The new code has been tested, and stores long answer strings, answer strings with UTF-8 characters, and prior last_answer data from the old format seems to load properly in all cases tested.
Change the serialization/deserialization code for the last_answer database field
Member
|
As far as I can tell there are no pending PRs or major issues for either pg or webwork2 remaining to hold off the release of 2.15. The following "minor" issues may need to be addressed with hotfixes: |
taniwallach
added
essentially ready to merge
and removed
NeedsTesting
Member
Author
|
@drgrice1 @taniwallach @Alex-Jordan @heiderich @drdrew42 @drjt @dpvc @dlglin
|
Contributor
|
I'm not aware of any reason to hold back. I can think of a few loose threads that are waiting now for 2.16. Thank you to all of you who have been working so hard on this release. I've only been involved with WW since about edition 2.7, but this seems to me to have been the heaviest lift so far, with some new features that have been years in the making, plus lots and lots of testing and debugging. Congratulations on reaching the end. |
Alex-Jordan
approved these changes
Oct 4, 2019
Alex-Jordan
reviewed
Oct 4, 2019
| $PG_VERSION ='2.15'; #beta!!! | ||
| $PG_COPYRIGHT_YEARS = '1996-2019'; | ||
|
|
||
| # this file is not being used (I believe) |
Contributor
There was a problem hiding this comment.
There is a comment here that this file is not being used. IIRC, because of something related to Docker, something is in place that assumes the PG and WW versions match. But that is not always true. I hope something is in place that faithfully displays which versions of PG and WW are being used on a given server.
Member
There was a problem hiding this comment.
I am pretty certain that comment is correct. Also, see line 33-34 of webwork2/conf/defaults.config and lines 220-243 of webwork2/lib/WeBWorK/CourseEnvironment.pm. The PG version is now obtained from pg/VERSION.
Member
Author
|
This was a link so that the version of PG only needed to be updated in one place. Docker had difficulties with the link. Docker and CourseEnvironment have been modified to provide a more robust way of reading the pg/VERSION file.
I will remove this link.
For a more complete history see Issue #929
|
…ide changes from working if not problem specific css file load was in use
…ss_files Patch for PR 1018
$ce->{PG_VERSION} is now obtained directly from the file pg/VERSION via a special exception which
allows CourseEnvironment to read that file. (Normally CourseEnvironment only has access to files in webwork2. )
Remove !!beta
We b wor k 2.15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a version containing multilingual features (utf8 4 byte characters). There are database changes so test cautiously (backup up the database just in case). If $ENABLE_UTF8MB4=0 you should be able to use this on existing sites, even with mysql databases earlier than 5.3. If you set $ENABLE_UTF8MB4=1 then you will get a "wide character" error message from the database if it is too old. If it is new enough you will be able to use all characters including Chinese, emoji, Arabic and so forth. (Download the companion PG-2.15-beta as well.)