[fix] Return False on true exceptions to avoid masking failures

Author: Eeshu-Yadav

.github/actions/bot-autoassign/issue_assignment_bot.py

@@ -281,7 +281,7 @@ def handle_issue_comment(self):
             issue_number = issue.get("number")
             if not all([comment_body, commenter, issue_number]):
                 print("Missing required comment data")
-                return True
+                return False
             if self.is_assignment_request(comment_body):
                 return self.respond_to_assignment_request(issue_number, commenter)
             print("Comment does not contain assignment request")
@@ -302,7 +302,7 @@ def handle_pull_request(self):
             pr_body = pr.get("body", "")
             if not all([pr_number, pr_author]):
                 print("Missing required PR data")
-                return True
+                return False
             if action in ["opened", "reopened"]:
                 self.auto_assign_issues_from_pr(pr_number, pr_author, pr_body)
                 # We consider the event handled even if no issues were linked

.github/actions/bot-autoassign/pr_reopen_bot.py

@@ -69,7 +69,7 @@ def handle_pr_reopen(self):
             pr_body = pr.get("body", "")
             if not all([pr_number, pr_author]):
                 print("Missing required PR data")
-                return True
+                return False
             print(f"Handling PR #{pr_number}" f" reopen by {pr_author}")
             reassigned = self.reassign_issues_to_author(pr_number, pr_author, pr_body)
             self.remove_stale_label(pr_number)
@@ -110,7 +110,7 @@ def handle_contributor_activity(self):
             )
             if not all([pr_number, commenter]):
                 print("Missing required comment data")
-                return True
+                return False
             if not issue_data.get("pull_request"):
                 print("Comment is on an issue," " not a PR, skipping")
                 return True

.github/actions/bot-autoassign/stale_pr_bot.py

@@ -148,7 +148,7 @@ def close_stale_pr(self, pr, days_inactive):
         try:
             pr_author = pr.user.login if pr.user else None
             if not pr_author:
-                return True
+                return False
             close_lines = [
                 "<!-- bot:closed -->",
                 f"Hi @{pr_author} 👋,",
@@ -210,7 +210,7 @@ def mark_pr_stale(self, pr, days_inactive):
         try:
             pr_author = pr.user.login if pr.user else None
             if not pr_author:
-                return True
+                return False
             unassign_lines = [
                 "<!-- bot:stale -->",
                 f"Hi @{pr_author} 👋,",
@@ -273,7 +273,7 @@ def send_stale_warning(self, pr, days_inactive):
         try:
             pr_author = pr.user.login if pr.user else None
             if not pr_author:
-                return True
+                return False
             remaining = self.DAYS_BEFORE_UNASSIGN - days_inactive
             warning_lines = [
                 "<!-- bot:stale_warning -->",