From ad683045fe7d3ea29475324490ddca1ef2176588 Mon Sep 17 00:00:00 2001 From: James Martinez Date: Tue, 28 Apr 2026 09:20:15 -0500 Subject: [PATCH 1/5] chore: switch to mise for dev environment --- .github/workflows/ci.yaml | 13 +++---------- .github/workflows/pkg-pr-new.yaml | 4 +--- CONTRIBUTING.md | 7 +++++++ mise.toml | 3 +++ package.json | 6 +----- 5 files changed, 15 insertions(+), 18 deletions(-) create mode 100644 mise.toml diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 3e357f2c..2b860b5e 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -25,9 +25,7 @@ jobs: --health-retries 5 steps: - uses: actions/checkout@v6 - - uses: actions/setup-node@v6 - with: - node-version-file: package.json + - uses: jdx/mise-action@v2 - run: npm ci - run: npm run ci - uses: codecov/codecov-action@v6 @@ -49,10 +47,7 @@ jobs: --health-retries 5 steps: - uses: actions/checkout@v6 - - uses: actions/setup-node@v6 - with: - node-version-file: package.json - - uses: oven-sh/setup-bun@v2 + - uses: jdx/mise-action@v2 - run: npm ci - run: bun run ci:bun # https://commitlint.js.org/guides/ci-setup.html @@ -62,9 +57,7 @@ jobs: - uses: actions/checkout@v6 with: fetch-depth: 0 - - uses: actions/setup-node@v6 - with: - node-version-file: package.json + - uses: jdx/mise-action@v2 - run: npm install -D @commitlint/cli @commitlint/config-conventional - name: Validate current commit (last commit) with commitlint if: github.event_name == 'push' diff --git a/.github/workflows/pkg-pr-new.yaml b/.github/workflows/pkg-pr-new.yaml index efd818c9..1db96202 100644 --- a/.github/workflows/pkg-pr-new.yaml +++ b/.github/workflows/pkg-pr-new.yaml @@ -11,9 +11,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v6 - - uses: actions/setup-node@v6 - with: - node-version-file: package.json + - uses: jdx/mise-action@v2 - run: npm ci - run: npm run build - run: > diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 9fb573db..af0ab3d9 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -21,3 +21,10 @@ why it belongs in OpenWorkflow. The core team will help confirm direction before any PRs start. PRs that skip these steps may be closed. + +## Development environment + +This repo uses [mise](https://mise.jdx.dev/) to pin Node and Bun versions. Once +you have mise installed, run `mise install` from the repo root to get the same +toolchain CI uses. Tool versions live in `mise.toml`; the GitHub Actions +workflows install them via `jdx/mise-action`. diff --git a/mise.toml b/mise.toml new file mode 100644 index 00000000..16ed5fce --- /dev/null +++ b/mise.toml @@ -0,0 +1,3 @@ +[tools] +node = "24" +bun = "1" diff --git a/package.json b/package.json index 920365cf..6304f18d 100644 --- a/package.json +++ b/package.json @@ -69,9 +69,5 @@ "typescript-eslint": "^8.59.0", "vitest": "^4.1.2" }, - "packageManager": "npm@11.8.0", - "engines": { - "node": ">=22.5.0", - "npm": ">=11" - } + "packageManager": "npm@11.8.0" } From ec567b033e622a1036daf8d162097f6bee9dd6b4 Mon Sep 17 00:00:00 2001 From: James Martinez Date: Tue, 28 Apr 2026 09:33:57 -0500 Subject: [PATCH 2/5] fix: node lts for dev, 22.5.0 for sqlite in prod --- CONTRIBUTING.md | 8 ++++---- package-lock.json | 48 ----------------------------------------------- 2 files changed, 4 insertions(+), 52 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index af0ab3d9..2ffc32ee 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -24,7 +24,7 @@ PRs that skip these steps may be closed. ## Development environment -This repo uses [mise](https://mise.jdx.dev/) to pin Node and Bun versions. Once -you have mise installed, run `mise install` from the repo root to get the same -toolchain CI uses. Tool versions live in `mise.toml`; the GitHub Actions -workflows install them via `jdx/mise-action`. +This repo uses [mise](https://mise.jdx.dev/) to manage the Node and Bun versions +used for development. Once you have mise installed, run `mise install` from the +repo root to install the versions configured in `mise.toml`. The GitHub Actions +workflows install those versions via `jdx/mise-action`. diff --git a/package-lock.json b/package-lock.json index f7780810..1edea93b 100644 --- a/package-lock.json +++ b/package-lock.json @@ -46,10 +46,6 @@ "typescript": "^6.0.3", "typescript-eslint": "^8.59.0", "vitest": "^4.1.2" - }, - "engines": { - "node": ">=22.5.0", - "npm": ">=11" } }, "apps/cli": { @@ -12952,36 +12948,6 @@ } } }, - "node_modules/nitro/node_modules/chokidar": { - "version": "5.0.0", - "resolved": "https://registry.npmjs.org/chokidar/-/chokidar-5.0.0.tgz", - "integrity": "sha512-TQMmc3w+5AxjpL8iIiwebF73dRDF4fBIieAqGn9RGCWaEVwQ6Fb2cGe31Yns0RRIzii5goJ1Y7xbMwo1TxMplw==", - "extraneous": true, - "license": "MIT", - "dependencies": { - "readdirp": "^5.0.0" - }, - "engines": { - "node": ">= 20.19.0" - }, - "funding": { - "url": "https://paulmillr.com/funding/" - } - }, - "node_modules/nitro/node_modules/readdirp": { - "version": "5.0.0", - "resolved": "https://registry.npmjs.org/readdirp/-/readdirp-5.0.0.tgz", - "integrity": "sha512-9u/XQ1pvrQtYyMpZe7DXKv2p5CNvyVwzUB6uhLAnQwHMSgKMBR62lc7AHljaeteeHXn11XTAaLLUVZYVZyuRBQ==", - "extraneous": true, - "license": "MIT", - "engines": { - "node": ">= 20.19.0" - }, - "funding": { - "type": "individual", - "url": "https://paulmillr.com/funding/" - } - }, "node_modules/nitro/node_modules/unstorage": { "version": "2.0.0-alpha.7", "resolved": "https://registry.npmjs.org/unstorage/-/unstorage-2.0.0-alpha.7.tgz", @@ -16552,20 +16518,6 @@ } } }, - "node_modules/vite-tsconfig-paths/node_modules/typescript": { - "version": "5.9.3", - "resolved": "https://registry.npmjs.org/typescript/-/typescript-5.9.3.tgz", - "integrity": "sha512-jl1vZzPDinLr9eUt3J/t7V6FgNEw9QjvBPdysz9KfQDD41fQrC2Y4vKQdiaUpFT4bXlb1RHhLpp8wtm6M5TgSw==", - "extraneous": true, - "license": "Apache-2.0", - "bin": { - "tsc": "bin/tsc", - "tsserver": "bin/tsserver" - }, - "engines": { - "node": ">=14.17" - } - }, "node_modules/vitefu": { "version": "1.1.3", "resolved": "https://registry.npmjs.org/vitefu/-/vitefu-1.1.3.tgz", From 7bc2adc011079d82e5f304bdf5117111f3631359 Mon Sep 17 00:00:00 2001 From: James Martinez Date: Tue, 28 Apr 2026 09:49:33 -0500 Subject: [PATCH 3/5] fix: bring back engines --- package-lock.json | 4 ++++ package.json | 6 +++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/package-lock.json b/package-lock.json index 1edea93b..e6bcf7e0 100644 --- a/package-lock.json +++ b/package-lock.json @@ -46,6 +46,10 @@ "typescript": "^6.0.3", "typescript-eslint": "^8.59.0", "vitest": "^4.1.2" + }, + "engines": { + "node": ">=22.5.0", + "npm": ">=11" } }, "apps/cli": { diff --git a/package.json b/package.json index 6304f18d..920365cf 100644 --- a/package.json +++ b/package.json @@ -69,5 +69,9 @@ "typescript-eslint": "^8.59.0", "vitest": "^4.1.2" }, - "packageManager": "npm@11.8.0" + "packageManager": "npm@11.8.0", + "engines": { + "node": ">=22.5.0", + "npm": ">=11" + } } From c6f248e376438810b872cc54f8e82de92435486d Mon Sep 17 00:00:00 2001 From: James Martinez Date: Tue, 28 Apr 2026 10:00:46 -0500 Subject: [PATCH 4/5] fix: back to node lts in mise --- mise.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mise.toml b/mise.toml index 16ed5fce..2acf4ae1 100644 --- a/mise.toml +++ b/mise.toml @@ -1,3 +1,3 @@ [tools] -node = "24" +node = "lts" bun = "1" From 37db50a578239d26b99789b5d7fa79a9bb4a7002 Mon Sep 17 00:00:00 2001 From: James Martinez Date: Tue, 28 Apr 2026 10:14:39 -0500 Subject: [PATCH 5/5] fix: document mise trust --- CONTRIBUTING.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 2ffc32ee..38d32aac 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -25,6 +25,7 @@ PRs that skip these steps may be closed. ## Development environment This repo uses [mise](https://mise.jdx.dev/) to manage the Node and Bun versions -used for development. Once you have mise installed, run `mise install` from the -repo root to install the versions configured in `mise.toml`. The GitHub Actions -workflows install those versions via `jdx/mise-action`. +used for development. Once you have mise installed, run `mise trust` followed by +`mise install` from the repo root to install the versions configured in +`mise.toml`. The GitHub Actions workflows install those versions via +`jdx/mise-action`.