Apply suggestions from code review

Co-authored-by: Anik  <anikbhattacharya93@gmail.com>
Co-authored-by: Joe Lanford <joe.lanford@gmail.com>

Author: 3 people

internal/operator-controller/rukpak/render/render.go

@@ -184,7 +184,7 @@ func defaultTargetNamespacesForBundle(rv1 *bundle.RegistryV1, installNamespace s
 	return nil
 }
 
-func getSupportedInstallModesSet(rv1 *bundle.RegistryV1) sets.Set[v1alpha1.InstallModeType] {
+func supportedInstallModes(rv1 *bundle.RegistryV1) sets.Set[v1alpha1.InstallModeType] {
 	supportedInstallModes := sets.New[v1alpha1.InstallModeType]()
 	for _, im := range rv1.CSV.Spec.InstallModes {
 		if im.Supported {

internal/operator-controller/rukpak/render/render_test.go

@@ -140,14 +140,14 @@ func Test_BundleRenderer_CreatesCorrectRenderOptions_WithDefaults(t *testing.T)
 		}, {
 			name:                   "returns error if target namespaces is not set bundle supports install modes [SingleNamespace]",
 			csv:                    MakeCSV(WithInstallModeSupportFor(v1alpha1.InstallModeTypeSingleNamespace)),
-			expectedErrMsgFragment: "at least one target namespace must be specified",
+			expectedErrMsgFragment: "exactly one target namespace must be specified",
 		}, {
 			name:                   "returns error if target namespaces is not set bundle supports install modes [MultiNamespace]",
-			csv:                    MakeCSV(WithInstallModeSupportFor(v1alpha1.InstallModeTypeSingleNamespace)),
+			csv:                    MakeCSV(WithInstallModeSupportFor(v1alpha1.InstallModeTypeMultiNamespace)),
 			expectedErrMsgFragment: "at least one target namespace must be specified",
 		}, {
 			name:                   "returns error if target namespaces is not set bundle supports install modes [SingleNamespace, MultiNamespace]",
-			csv:                    MakeCSV(WithInstallModeSupportFor(v1alpha1.InstallModeTypeSingleNamespace)),
+			csv:                    MakeCSV(WithInstallModeSupportFor(v1alpha1.InstallModeTypeSingleNamespace, v1alpha1.InstallModeTypeMultiNamespace)),
 			expectedErrMsgFragment: "at least one target namespace must be specified",
 		},
 	} {