update

Author: raju-opti

lib/project_config/project_config.spec.ts

@@ -329,7 +329,7 @@ const getHoldoutDatafile = () => {
       key: 'holdout_2',
       status: 'Running',
       includedFlags: [],
-      excludedFlags: ['44829230000'],
+      excludedFlags: [],
       audienceIds: [],
       audienceConditions: [],
       variations: [
@@ -350,7 +350,7 @@ const getHoldoutDatafile = () => {
       id: 'holdout_id_3',
       key: 'holdout_3',
       status: 'Draft',
-      includedFlags: ['4482920077'],
+      includedFlags: [],
       excludedFlags: [],
       audienceIds: [],
       audienceConditions: [],
@@ -402,6 +402,18 @@ describe('createProjectConfig - holdouts', () => {
     expect(configObj.holdouts).toEqual([]);
     expect(configObj.holdoutIdMap).toEqual({});
   });
+
+  it('should handle undefined includedFlags and excludedFlags in holdout', function() {
+    const datafile = getHoldoutDatafile();
+    datafile.holdouts[0].includedFlags = undefined;
+    datafile.holdouts[0].excludedFlags = undefined;
+
+    const configObj = projectConfig.createProjectConfig(JSON.parse(JSON.stringify(datafile)));
+
+    expect(configObj.holdouts).toHaveLength(3);
+    expect(configObj.holdouts[0].includedFlags).toEqual([]);
+    expect(configObj.holdouts[0].excludedFlags).toEqual([]);
+  });
 });
 
 describe('getExperimentId', () => {

lib/project_config/project_config.ts

@@ -388,6 +388,12 @@ const parseHoldoutsConfig = (projectConfig: ProjectConfig): void => {
   projectConfig.holdoutIdMap = keyBy(projectConfig.holdouts, 'id');
 
   projectConfig.holdouts.forEach((holdout) => {
+
+    // Original design of the global holdouts made use of the includeFlags and excludeFlags fields to identify local holdouts.
+    // But this was never released. In the current design, these fields are no longer user. These fields are kept
+    // and assinged empty array to keep the published type `Holdout` unchanged.
+    holdout.includedFlags = [];
+    holdout.excludedFlags = [];
     holdout.variationKeyMap = keyBy(holdout.variations, 'key');
     assignBy(holdout.variations, 'id', projectConfig.variationIdMap);
   });

lib/shared_types.ts

@@ -174,6 +174,8 @@ export type HoldoutStatus = 'Draft' | 'Running' | 'Concluded' | 'Archived';
 
 export interface Holdout extends ExperimentCore {
   status: HoldoutStatus;
+  includedFlags: string[];
+  excludedFlags: string[];
 }
 
 export function isHoldout(obj: Experiment | Holdout): obj is Holdout {