Replies: 6 comments 1 reply
-
|
If Relevant , I can work on this feature @marcvergees @vharkins1 @juanalvv @manucargar |
Beta Was this translation helpful? Give feedback.
-
|
There's kind of a trade-off in open-source projects because sometimes it's a common practice to leave it unpinned to get benefited of any kind of package update. By the same reason, it can give us inestability in the code. |
Beta Was this translation helpful? Give feedback.
-
|
What do you think guys we should do here? @vharkins1 @abhishek-8081 @chetanr25. |
Beta Was this translation helpful? Give feedback.
-
|
Hey @itvi-1234, For now, since the backend architecture is still being designed and the list of dependencies is not finalized yet, pinning versions at this stage might only be a temporary fix and could require frequent updates later. I think this can be kept as a lower priority for now, and once the core backend requirements are finalized by mentors, we can properly finalize and pin all required package versions. tldr; Let me know your thoughts @marcvergees @vharkins1 @abhishek-8081 |
Beta Was this translation helpful? Give feedback.
-
|
I think the concern raised in the issue is valid, especially regarding reproducible builds and Docker stability. Missing dependencies like However, I also agree that since the backend stack is still evolving, strict pinning of every dependency right now may lead to frequent maintenance updates. A better approach for the current stage could be:
Overall, I also feel this is important but not urgent at the current stage. |
Beta Was this translation helpful? Give feedback.
-
|
Closing this discussion as the issue is of low priority and we will definitely fix it in the upcoming iterations. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
name: 🚀 Feature Request
about: Suggest an idea or a new capability for FireForm.
title: "[FEAT]: Pin Dependency Versions in requirements.txt"
labels: enhancement
assignees: ''
📝 Description
Update
requirements.txtto include explicit version numbers for all dependencies (e.g.,requests==2.31.0), and ensure all used dependencies (likepypdf) are actually stated in the file.💡 Rationale
Currently,
requirements.txtlacks version pinning and is missingpypdf. Installing packages blindly ensures varying results on distinct machines based on whatever edge version is currently published aslateston PyPI. This can silently introduce breaking changes inside Docker build processes.🛠️ Proposed Solution
A brief sketch of how we might implement this.
requirements.txtwith specific pinned versions (usingpip freeze).pypdftorequirements.txt.✅ Acceptance Criteria
How will we know this is finished?
Beta Was this translation helpful? Give feedback.
All reactions