fix: public storage role

23doors · 23doors · commit 7cebee5ba949 · 2026-03-12T13:01:28.000+01:00
diff --git a/gcp/bucket.go b/gcp/bucket.go
@@ -108,7 +108,7 @@ func (o *Bucket) Read(ctx context.Context, meta any) error {
 		return fmt.Errorf("error fetching bucket policy: %w", err)
 	}
 
-	o.Public.SetCurrent(policy.HasRole(ACLAllUsers, "roles/storage.objectViewer"))
+	o.Public.SetCurrent(policy.HasRole(ACLAllUsers, "roles/storage.legacyObjectReader"))
 
 	return nil
 }
@@ -176,7 +176,7 @@ func (o *Bucket) Create(ctx context.Context, meta any) error {
 		return fmt.Errorf("error fetching bucket policy: %w", err)
 	}
 
-	policy.Add(ACLAllUsers, "roles/storage.objectViewer")
+	policy.Add(ACLAllUsers, "roles/storage.legacyObjectReader")
 
 	err = b.IAM().SetPolicy(ctx, policy)
 	if err != nil {
@@ -255,9 +255,9 @@ func (o *Bucket) Update(ctx context.Context, meta any) error {
 	}
 
 	if o.Public.Wanted() {
-		policy.Add(ACLAllUsers, "roles/storage.objectViewer")
+		policy.Add(ACLAllUsers, "roles/storage.legacyObjectReader")
 	} else {
-		policy.Remove(ACLAllUsers, "roles/storage.objectViewer")
+		policy.Remove(ACLAllUsers, "roles/storage.legacyObjectReader")
 	}
 
 	err = b.IAM().SetPolicy(ctx, policy)

Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,7 @@ func (o *Bucket) Read(ctx context.Context, meta any) error {`
`108`	`108`	`return fmt.Errorf("error fetching bucket policy: %w", err)`
`109`	`109`	`}`
`110`	`110`
`111`		`- o.Public.SetCurrent(policy.HasRole(ACLAllUsers, "roles/storage.objectViewer"))`
	`111`	`+ o.Public.SetCurrent(policy.HasRole(ACLAllUsers, "roles/storage.legacyObjectReader"))`
`112`	`112`
`113`	`113`	`return nil`
`114`	`114`	`}`
`@@ -176,7 +176,7 @@ func (o *Bucket) Create(ctx context.Context, meta any) error {`
`176`	`176`	`return fmt.Errorf("error fetching bucket policy: %w", err)`
`177`	`177`	`}`
`178`	`178`
`179`		`- policy.Add(ACLAllUsers, "roles/storage.objectViewer")`
	`179`	`+ policy.Add(ACLAllUsers, "roles/storage.legacyObjectReader")`
`180`	`180`
`181`	`181`	`err = b.IAM().SetPolicy(ctx, policy)`
`182`	`182`	`if err != nil {`
`@@ -255,9 +255,9 @@ func (o *Bucket) Update(ctx context.Context, meta any) error {`
`255`	`255`	`}`
`256`	`256`
`257`	`257`	`if o.Public.Wanted() {`
`258`		`- policy.Add(ACLAllUsers, "roles/storage.objectViewer")`
	`258`	`+ policy.Add(ACLAllUsers, "roles/storage.legacyObjectReader")`
`259`	`259`	`} else {`
`260`		`- policy.Remove(ACLAllUsers, "roles/storage.objectViewer")`
	`260`	`+ policy.Remove(ACLAllUsers, "roles/storage.legacyObjectReader")`
`261`	`261`	`}`
`262`	`262`
`263`	`263`	`err = b.IAM().SetPolicy(ctx, policy)`