From 517bcdf3b2f5e59bf0933a49fdc08dbf7cb50260 Mon Sep 17 00:00:00 2001
From: Nick Charney Kaye <charneykaye@gmail.com>
Date: Thu, 23 Jul 2026 09:31:29 -0400
Subject: [PATCH] Linux Steam depot: version.txt stamp for the version-stable
 AppImage

The v0.2.4 steam-deploy run failed artifact inspection:
TestVersionStamping::test_installer_filename_contains_semver expects a
semver in installer filenames, but the Linux depot now deliberately ships
ConversationSimulator.AppImage under a version-stable name so the
Steamworks launch option survives version bumps.

- steam-deploy.yml: stamp version.txt (derived from the versioned build
  artifact filename) into steam-content/linux/, mirroring the Windows
  portable depot convention.
- artifact inspection: filename-based version checks now skip when the
  depot root carries a semver version.txt stamp, and the 0.0.0-placeholder
  check validates the stamp itself.
---
 .github/workflows/steam-deploy.yml         | 11 +++++++
 tests/artifact/test_artifact_inspection.py | 34 ++++++++++++++++++++++
 2 files changed, 45 insertions(+)

diff --git a/.github/workflows/steam-deploy.yml b/.github/workflows/steam-deploy.yml
index 199f27ed..d70aa287 100644
--- a/.github/workflows/steam-deploy.yml
+++ b/.github/workflows/steam-deploy.yml
@@ -311,6 +311,17 @@ jobs:
           if [ -n "$APPIMAGE" ]; then
             echo "Staging $APPIMAGE -> steam-content/linux/ConversationSimulator.AppImage"
             cp "$APPIMAGE" steam-content/linux/ConversationSimulator.AppImage
+            # Depot version stamp: the AppImage ships under a version-stable
+            # filename, so the version lives in version.txt at the depot root
+            # (same convention as the Windows portable depot).  Derived from
+            # the versioned artifact filename produced by the release build.
+            V="$(basename "$APPIMAGE" | grep -oE '[0-9]+[.][0-9]+[.][0-9]+' | head -n1)"
+            if [ -n "$V" ]; then
+              printf '%s' "$V" > steam-content/linux/version.txt
+              echo "Stamped Linux depot version.txt: $V"
+            else
+              echo "WARNING: could not derive version from AppImage filename; no version.txt stamped" >&2
+            fi
           else
             echo "WARNING: no AppImage found in build artifacts - Linux depot will be empty" >&2
           fi
diff --git a/tests/artifact/test_artifact_inspection.py b/tests/artifact/test_artifact_inspection.py
index 8a3b38a0..da724575 100644
--- a/tests/artifact/test_artifact_inspection.py
+++ b/tests/artifact/test_artifact_inspection.py
@@ -83,6 +83,23 @@ def _is_windows_portable_depot(artifact_dir: Path) -> bool:
     """
     return (artifact_dir / "ConversationSimulator.exe").is_file()
 
+def _has_depot_version_stamp(artifact_dir: Path) -> bool:
+    """Return True if artifact_dir carries a semver version.txt depot stamp.
+
+    Depots that ship version-stable filenames carry their version in
+    version.txt at the depot root instead of in filenames: the Windows
+    portable depot (ConversationSimulator.exe tree) and the Linux depot
+    (ConversationSimulator.AppImage).  Steamworks launch options reference
+    these filenames, so a version bump must not rename them; v0.2.3 shipped
+    a versioned AppImage filename and left the Linux launch option pinned to
+    a name that would have broken on the next release.
+    """
+    stamp = artifact_dir / "version.txt"
+    try:
+        return bool(_SEMVER.search(stamp.read_text(encoding="utf-8").strip()))
+    except OSError:
+        return False
+
 
 def _is_pyinstaller_internal(path: Path) -> bool:
     """Return True if path is inside a PyInstaller _internal/ directory.
@@ -264,6 +281,12 @@ def test_installer_filename_contains_semver(
                 "Windows portable depot — version is in version.txt, "
                 "not in binary filenames"
             )
+        if _has_depot_version_stamp(artifact_dir):
+            pytest.skip(
+                "Depot ships version-stable filenames (see the Steamworks "
+                "launch options) - version is stamped in version.txt at the "
+                "depot root"
+            )
         installers = [
             f
             for f in all_file_paths
@@ -290,6 +313,17 @@ def test_version_is_not_zero_placeholder(
                 "Windows portable depot — version.txt (not a filename) is "
                 "checked for the 0.0.0 placeholder by TestWindowsPortableLayout"
             )
+        stamp = artifact_dir / "version.txt"
+        if stamp.is_file():
+            stamped = stamp.read_text(encoding="utf-8").strip()
+            assert stamped != "0.0.0", (
+                "version.txt contains the 0.0.0 placeholder - the version "
+                "stamp step may not have run for this depot."
+            )
+            pytest.skip(
+                "Depot version lives in version.txt (checked above), not in "
+                "filenames"
+            )
         installers = [
             f
             for f in all_file_paths