Maestro V5 - Refactoring

[leoraba]

Summary of request

To keep track of the feedback from PR#286.

List of tasks:

• Module Server Controller: Indexing Repository function could be a very long running process, we probably don't want to hold the web request until the indexing is complete. Should we instead return status 200 and state that the request has been started? fixed ✅
• Module Indexer operations: Consider chunking the input data. ES has a max request size, so if you try to index too much in a single request it will fail.
• Module Indexer operations: Differentiate response in following cases:
  • success
  • failure, errors in upload operation
  • failure, caught error during execution, network error or similar
• Module provider api: Do we wan't to return or throw the error while creating the Repository, instead of waiting for it to be used? This let's the operator know that the setup failed during the setup step, instead of at a later point when using the repositories that were setup. fixed ✅
• Module provider api: This file is not the controller for the web request, so it probably shouldn't be throwing errors associated with the web request instead return Result object with properties success, reason and message. fixed ✅
• Module Repository: Move this package within maestro-provider package.
• Module common types: Move Repository interface to repository package. Have LyricRepository and SongRepository as importable implementations of this interface.