Skip to content

Commit e97075b

Browse files
committed
Fix async store reset wiping newly registered cells on example switch
1 parent 654c88d commit e97075b

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

src/routes/[package]/[version]/examples/[slug]/+page.svelte

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
import Tooltip from '$lib/components/common/Tooltip.svelte';
77
import { packageVersionsStore } from '$lib/stores/packageVersionsStore';
88
import { exampleGroupsStore } from '$lib/stores/examplesContext';
9-
import { notebookStore } from '$lib/stores/notebookStore';
109
import { groupByCategory } from '$lib/notebook/manifest';
1110
import { packages } from '$lib/config/packages';
1211
import type { PageData } from './$types';
@@ -40,19 +39,17 @@
4039
});
4140
4241
// Reset Pyodide namespace when example changes (but don't terminate)
42+
// {#key} on Notebook handles component destruction and store cleanup via onDestroy
4343
$effect(() => {
4444
const slug = data.meta.slug;
4545
46-
// Reset namespace when switching examples
47-
// Note: {#key} on Notebook handles component destruction and store cleanup
4846
return async () => {
4947
try {
5048
const { reset } = await import('$lib/pyodide');
5149
await reset();
5250
} catch {
5351
// Ignore if Pyodide not loaded
5452
}
55-
notebookStore.reset();
5653
};
5754
});
5855

0 commit comments

Comments
 (0)