diff --git a/packages/react-core/src/components/DualListSelector/DualListSelectorTreeItem.tsx b/packages/react-core/src/components/DualListSelector/DualListSelectorTreeItem.tsx index 71c9f800d33..0478448e696 100644 --- a/packages/react-core/src/components/DualListSelector/DualListSelectorTreeItem.tsx +++ b/packages/react-core/src/components/DualListSelector/DualListSelectorTreeItem.tsx @@ -3,7 +3,7 @@ import styles from '@patternfly/react-styles/css/components/DualListSelector/dua import { css } from '@patternfly/react-styles'; import { DualListSelectorTreeItemData } from './DualListSelectorTree'; import { Badge } from '../Badge'; -import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon'; +import RhMicronsCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-right-icon'; import { flattenTree } from './treeUtils'; import { DualListSelectorListContext } from './DualListSelectorContext'; import { useHasAnimations } from '../../helpers'; @@ -136,7 +136,7 @@ const DualListSelectorTreeItemBase: React.FunctionComponent - + )} diff --git a/packages/react-core/src/components/Hero/Hero.tsx b/packages/react-core/src/components/Hero/Hero.tsx index 88946e29d47..f0cf81cbbf4 100644 --- a/packages/react-core/src/components/Hero/Hero.tsx +++ b/packages/react-core/src/components/Hero/Hero.tsx @@ -53,7 +53,7 @@ export const Hero: React.FunctionComponent = ({ bodyWidth, bodyMaxWidth, ...props -}) => { +}: HeroProps) => { const customStyles: { [key: string]: string } = {}; if (backgroundSrcLight) { customStyles[heroBackgroundImageLight.name] = `url(${backgroundSrcLight})`; diff --git a/packages/react-core/src/components/Popover/Popover.tsx b/packages/react-core/src/components/Popover/Popover.tsx index 9585a13bf7d..f43ac7f38b4 100644 --- a/packages/react-core/src/components/Popover/Popover.tsx +++ b/packages/react-core/src/components/Popover/Popover.tsx @@ -205,9 +205,11 @@ export interface PopoverProps { shouldOpen?: (event: MouseEvent | KeyboardEvent, showFunction?: () => void) => void; /** Flag indicating whether the close button should be shown. */ showClose?: boolean; - /** Sets an interaction to open popover, defaults to "click" */ + /** @deprecated Sets an interaction to open popover, defaults to "click" */ triggerAction?: 'click' | 'hover'; - /** Whether to trap focus in the popover. */ + /** Whether to trap focus in the popover. When using a triggerAction of "hover", this will be set to false + * by default and must remain false. + */ withFocusTrap?: boolean; /** The z-index of the popover. */ zIndex?: number; @@ -267,7 +269,7 @@ export const Popover: React.FunctionComponent = ({ ], animationDuration = 300, id, - withFocusTrap: propWithFocusTrap, + withFocusTrap: propWithFocusTrap = triggerAction === 'hover' ? false : undefined, triggerRef, hasNoPadding = false, hasAutoWidth = false, diff --git a/packages/react-core/src/components/Popover/examples/Popover.md b/packages/react-core/src/components/Popover/examples/Popover.md index 7755154fd84..a3017b4f971 100644 --- a/packages/react-core/src/components/Popover/examples/Popover.md +++ b/packages/react-core/src/components/Popover/examples/Popover.md @@ -25,7 +25,11 @@ By default, the `appendTo` prop of the popover will append to the document body ### Hoverable -```ts file="./PopoverHover.tsx" +Pass the `triggerAction="hover"` property to make a `` that is triggered via hover and focus rather than on click. When using a hoverable Popover, you **must not** include any interactive or semantic content (e.g. buttons, links, headings, lists, etc), as focus is not intended to enter a hoverable ``. Including such content may cause an inaccessible UI for users who are not able to reach the content when navigating via assistive tech. + +It is instead recommended to use our [tooltip component](/components/tooltip). + +```ts isDeprecated file="./PopoverHover.tsx" ``` diff --git a/packages/react-core/src/components/TreeView/TreeViewListItem.tsx b/packages/react-core/src/components/TreeView/TreeViewListItem.tsx index b2125e2763e..4ce5a4efeef 100644 --- a/packages/react-core/src/components/TreeView/TreeViewListItem.tsx +++ b/packages/react-core/src/components/TreeView/TreeViewListItem.tsx @@ -1,7 +1,7 @@ import { memo, useState, useEffect, Children, isValidElement, cloneElement } from 'react'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/TreeView/tree-view'; -import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon'; +import RhMicronsCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-right-icon'; import { TreeViewDataItem } from './TreeView'; import { Badge } from '../Badge'; import { useSSRSafeId } from '../../helpers'; @@ -155,7 +155,7 @@ const TreeViewListItemBase: React.FunctionComponent = ({ tabIndex={-1} > - + ); diff --git a/packages/react-core/src/components/TreeView/__tests__/__snapshots__/TreeViewListItem.test.tsx.snap b/packages/react-core/src/components/TreeView/__tests__/__snapshots__/TreeViewListItem.test.tsx.snap index 018e0f12858..9844b00c562 100644 --- a/packages/react-core/src/components/TreeView/__tests__/__snapshots__/TreeViewListItem.test.tsx.snap +++ b/packages/react-core/src/components/TreeView/__tests__/__snapshots__/TreeViewListItem.test.tsx.snap @@ -36,7 +36,7 @@ exports[`Matches snapshot with children 1`] = ` width="1em" > diff --git a/packages/react-docs/package.json b/packages/react-docs/package.json index efbe585f78d..3e21de2890e 100644 --- a/packages/react-docs/package.json +++ b/packages/react-docs/package.json @@ -37,7 +37,7 @@ "victory": "^37.3.6" }, "devDependencies": { - "@patternfly/documentation-framework": "^6.36.8", + "@patternfly/documentation-framework": "^6.40.0", "@patternfly/patternfly-a11y": "5.1.0" }, "keywords": [ diff --git a/packages/react-table/src/components/Table/utils/decorators/treeRow.tsx b/packages/react-table/src/components/Table/utils/decorators/treeRow.tsx index ada55534c74..c4269bb0c33 100644 --- a/packages/react-table/src/components/Table/utils/decorators/treeRow.tsx +++ b/packages/react-table/src/components/Table/utils/decorators/treeRow.tsx @@ -4,7 +4,7 @@ import styles from '@patternfly/react-styles/css/components/Table/table'; import stylesTreeView from '@patternfly/react-styles/css/components/Table/table-tree-view'; import { Button } from '@patternfly/react-core/dist/esm/components/Button'; import { Checkbox } from '@patternfly/react-core/dist/esm/components/Checkbox'; -import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon'; +import RhMicronsCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-right-icon'; import RhUiEllipsisHorizontalFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-ellipsis-horizontal-fill-icon'; export const treeRow = @@ -54,7 +54,7 @@ export const treeRow = aria-label={toggleAriaLabel || `${isExpanded ? 'Collapse' : 'Expand'} row ${rowIndex}`} icon={
- +
} /> diff --git a/yarn.lock b/yarn.lock index 88a84b0b3ce..cae48017c82 100644 --- a/yarn.lock +++ b/yarn.lock @@ -4963,9 +4963,9 @@ __metadata: languageName: node linkType: hard -"@patternfly/documentation-framework@npm:^6.36.8": - version: 6.36.8 - resolution: "@patternfly/documentation-framework@npm:6.36.8" +"@patternfly/documentation-framework@npm:^6.40.0": + version: 6.49.2 + resolution: "@patternfly/documentation-framework@npm:6.49.2" dependencies: "@babel/core": "npm:^7.29.0" "@babel/preset-env": "npm:7.29.0" @@ -5026,16 +5026,16 @@ __metadata: webpack-dev-server: "npm:5.2.3" webpack-merge: "npm:5.10.0" peerDependencies: - "@patternfly/patternfly": ^6.5.0-prerelease.46 - "@patternfly/react-code-editor": ^6.5.0-prerelease.39 - "@patternfly/react-core": ^6.5.0-prerelease.36 - "@patternfly/react-icons": ^6.5.0-prerelease.15 - "@patternfly/react-table": ^6.5.0-prerelease.37 + "@patternfly/patternfly": ^6.6.0 + "@patternfly/react-code-editor": ^6.6.0 + "@patternfly/react-core": ^6.6.0 + "@patternfly/react-icons": ^6.6.0 + "@patternfly/react-table": ^6.6.0 react: ^17.0.0 || ^18.0.0 react-dom: ^17.0.0 || ^18.0.0 bin: pf-docs-framework: scripts/cli/cli.js - checksum: 10c0/bf29256be06e32e130d6146a8d5cc9744e0b88463b69f9c2ef6bae98f0ffee15901760fb69c3737d7fdcf2d612511d034c7661568c92187ead143fe772f8d561 + checksum: 10c0/1d80d9d6078237d17b71deeb4ffa4b7ad6ed43c0d424c6044de4420d5ef8267eb913e281fc97ffa9fe6d6e70b0462557c22fdf50ecca9df555163eb48ab40ff5 languageName: node linkType: hard @@ -5191,7 +5191,7 @@ __metadata: version: 0.0.0-use.local resolution: "@patternfly/react-docs@workspace:packages/react-docs" dependencies: - "@patternfly/documentation-framework": "npm:^6.36.8" + "@patternfly/documentation-framework": "npm:^6.40.0" "@patternfly/patternfly": "npm:^6.6.0" "@patternfly/patternfly-a11y": "npm:5.1.0" "@patternfly/react-charts": "workspace:^"