From 916cf0a70a904448911c438cf05536418c723355 Mon Sep 17 00:00:00 2001 From: pbean Date: Mon, 15 Jun 2026 09:47:21 -0700 Subject: [PATCH 1/2] fix(ipc): import AsRawHandle for Windows raw handle (CI clippy) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The #[cfg(windows)] branch of raw_conn() called s.as_handle().as_raw_handle() but only imported AsHandle, so as_raw_handle() (provided by the AsRawHandle trait) was not in scope — a hard E0599 compile error that only surfaced on the Windows CI clippy job (the path is never compiled on Linux/macOS). Mirror the Unix branch and import both traits. Co-Authored-By: Claude Opus 4.8 --- src-tauri/src/ipc/socket_server.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src-tauri/src/ipc/socket_server.rs b/src-tauri/src/ipc/socket_server.rs index d2d0be0..9441205 100644 --- a/src-tauri/src/ipc/socket_server.rs +++ b/src-tauri/src/ipc/socket_server.rs @@ -400,7 +400,7 @@ fn raw_conn(stream: &Stream) -> RawConn { } #[cfg(windows)] Stream::NamedPipe(s) => { - use std::os::windows::io::AsHandle; + use std::os::windows::io::{AsHandle, AsRawHandle}; RawConn { handle: s.as_handle().as_raw_handle(), } From 1886c99b77e7f8e366b7db8e009fb044febb7985 Mon Sep 17 00:00:00 2001 From: pbean Date: Mon, 15 Jun 2026 09:47:21 -0700 Subject: [PATCH 2/2] fix(ci): build notey-cli before Linux E2E live-sync suite The P1-E2E-003 CLI live-sync suite spawns the standalone `notey` binary from notey-cli/target/debug/, but CI never built that workspace-less crate (the tauri build only covers src-tauri), so the spawn failed with ENOENT. Add a Linux-only build step before the E2E run and extend the Cargo cache to cover notey-cli/target/. Co-Authored-By: Claude Opus 4.8 --- .github/workflows/ci.yml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5d48e37..009a515 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -50,7 +50,8 @@ jobs: ~/.cargo/registry/cache/ ~/.cargo/git/db/ src-tauri/target/ - key: ${{ runner.os }}-cargo-${{ hashFiles('src-tauri/Cargo.lock') }} + notey-cli/target/ + key: ${{ runner.os }}-cargo-${{ hashFiles('src-tauri/Cargo.lock', 'notey-cli/Cargo.lock') }} restore-keys: | ${{ runner.os }}-cargo- @@ -100,6 +101,14 @@ jobs: if: runner.os == 'Linux' run: npx tauri build --debug --no-bundle + - name: Build notey-cli (Linux) + # The CLI live-sync E2E suite spawns the standalone `notey` binary from + # notey-cli/target/debug/. It's a separate, workspace-less crate not built + # by the tauri build above, so build it explicitly before E2E. + if: runner.os == 'Linux' + working-directory: notey-cli + run: cargo build + - name: E2E tests (Linux) if: runner.os == 'Linux' # WebKitGTK's accelerated compositing / DMABUF renderer crashes the web