odbc back-end resource handling broken on PHP 8.4

[MarkMaldaba]

Note: This task is similar to #37 which raised similar issues with the pgsql back-end, on PHP 8.1

Since PHP 8.4, various odbc methods now return a PHP object rather than a resource.

From https://www.php.net/manual/en/migration84.incompatible.php#migration84.incompatible.resource2object.odbc:

Several resources have been migrated to objects. Return value checks using is_resource() should be replaced with checks for false, unless specified otherwise.

• The ODBC functions now accept and return Odbc\Result objects instead of odbc_result resources.
• The ODBC functions now accept and return Odbc\Connection objects instead of odbc_connection resources.

In PEAR::DB, the DB_pdbc class is implemented on the assumption that the returned result is a PHP resource reference. In particular, there are various is_resource() checks that will no longer work as expected as this function only returns true for the resource implementation.

The class needs to be updated to handle both implementations, in order to support older PHP versions as well as continuing to run on PHP >= 8.4.

[DanCld]

It does not feel there is more than copy / pasting from what I have come up with for PgSQL. Unfortunately that pull request is still in the queue, so there may not be that many people affected by these changes to start with.

[schengawegga]

It does not feel there is more than copy / pasting from what I have come up with for PgSQL. Unfortunately that pull request is still in the queue, so there may not be that many people affected by these changes to start with.

I wrote a change request on your pull request.
After you made the change PHP5 compatible, i will merge your PR.
So maybe this issue will be fixed then, too?

[MarkMaldaba]

It does not feel there is more than copy / pasting from what I have come up with for PgSQL. Unfortunately that pull request is still in the queue, so there may not be that many people affected by these changes to start with.

I wrote a change request on your pull request. After you made the change PHP5 compatible, i will merge your PR. So maybe this issue will be fixed then, too?

I couldn't see a change request in PR #43, so I've submitted one of my own.

[DanCld]

I have updated my PR as per comments. TBH, I only got to modifying this code after I started running into issues when updating some legacy product to make it work with PHP 8.3+, so backwards compatibility was not top of mind for me. But thank you for pointing it out.

[DanCld]

I have added a draft PR for this: #47 . I have no means to test it out myself, so please feel free to copy/paste and see if it makes any difference.

[schengawegga]

@MarkMaldaba Have you any possibility to check the PR #47 from @DanCld ?

[MarkMaldaba]

@MarkMaldaba Have you any possibility to check the PR #47 from @DanCld ?

I'm afraid I don't have the facility to test the ODBC driver in action. I can give the PR a manual inspection, but I don't know if that's good enough to approve it.