From 40bd39a81a378abd6863e989a6b9b10fdb21dbba Mon Sep 17 00:00:00 2001 From: Brentley Jones Date: Fri, 1 May 2026 09:00:46 -0500 Subject: [PATCH] Expose stable Bazel generated visibility target --- CHANGELOG.md | 2 +- README.md | 2 +- bazel/BUILD.bazel | 4 ++++ bazel/generated.bzl | 8 ++++++++ 4 files changed, 14 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 01a21b3a05..122555fa92 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,7 +6,7 @@ ##### Enhancements -- None. +- Expose a stable `@periphery//bazel:generated` package group so Bazel projects can grant visibility to Periphery's generated scan target and use `--bazel-check-visibility` safely. ##### Bug Fixes diff --git a/README.md b/README.md index 17d3ad87a8..7972dc8fe6 100644 --- a/README.md +++ b/README.md @@ -463,7 +463,7 @@ The `--bazel` option enables Bazel mode, which provides seamless integration wit > [!TIP] > By default, Periphery passes `--check_visibility=false` to `bazel run` to simplify integration, since the generated scan target references your project's targets which may not otherwise be visible. However, disabling visibility checking can invalidate Bazel's analysis cache, resulting in slower subsequent builds. > -> You can disable this behavior with the `--bazel-check-visibility` option. You must ensure the necessary targets are visible to the generated package by adding the `@@+generated+periphery_generated//:__pkg__` visibility label to your targets. +> You can disable this behavior with the `--bazel-check-visibility` option. You must ensure the necessary targets are visible to Periphery's generated package, for example by adding the `@@+generated+periphery//bazel:generated` visibility label to your targets. ### Other diff --git a/bazel/BUILD.bazel b/bazel/BUILD.bazel index e69de29bb2..47b463a751 100644 --- a/bazel/BUILD.bazel +++ b/bazel/BUILD.bazel @@ -0,0 +1,4 @@ +package_group( + name = "generated", + includes = ["@periphery_generated//visibility:package_group"], +) diff --git a/bazel/generated.bzl b/bazel/generated.bzl index d7cb8665cb..389703ea60 100644 --- a/bazel/generated.bzl +++ b/bazel/generated.bzl @@ -3,6 +3,14 @@ """ def _generated_repo_impl(repository_ctx): + repository_ctx.file( + "visibility/BUILD.bazel", + """package_group( + name = "package_group", + packages = ["//..."], +) +""", + ) repository_ctx.symlink( "/var/tmp/periphery_bazel/BUILD.bazel", "BUILD.bazel",