From c34bfc2bf99b4b666af799ede43ebb15ec74c3b4 Mon Sep 17 00:00:00 2001 From: Andreas Hubert Date: Thu, 7 May 2026 16:05:28 +0000 Subject: [PATCH] PFX-WB-039 add hidden captions to security detail tables Worker-Model: openai-codex/gpt-5.3-codex Worker-Thinking: high --- .../live/security_detail_live.ex | 12 ++++++++++ .../live/security_detail_live_test.exs | 24 +++++++++++++++++++ 2 files changed, 36 insertions(+) diff --git a/lib/portfolixir_web/live/security_detail_live.ex b/lib/portfolixir_web/live/security_detail_live.ex index 5b5fa12..8a0e120 100644 --- a/lib/portfolixir_web/live/security_detail_live.ex +++ b/lib/portfolixir_web/live/security_detail_live.ex @@ -130,6 +130,9 @@ defmodule PortfolixirWeb.SecurityDetailLive do
+ @@ -176,6 +179,9 @@ defmodule PortfolixirWeb.SecurityDetailLive do <% else %>
+ <%= gettext("Security master data table with identifiers and provider mapping.") %> +
<%= gettext("Name") %>
+ @@ -225,6 +231,9 @@ defmodule PortfolixirWeb.SecurityDetailLive do <% else %>
+ <%= gettext("Fund documents table with filename, type, source, extraction status, and creation date.") %> +
<%= gettext("Original filename") %>
+ @@ -260,6 +269,9 @@ defmodule PortfolixirWeb.SecurityDetailLive do <% else %>
+ <%= gettext("Current position table with securities account and quantity.") %> +
<%= gettext("Securities account") %>
+ diff --git a/test/portfolixir_web/live/security_detail_live_test.exs b/test/portfolixir_web/live/security_detail_live_test.exs index d795eeb..10cd62e 100644 --- a/test/portfolixir_web/live/security_detail_live_test.exs +++ b/test/portfolixir_web/live/security_detail_live_test.exs @@ -65,6 +65,12 @@ defmodule PortfolixirWeb.SecurityDetailLiveTest do assert has_element?(view, "#security-master-data", "A1B2C3") assert has_element?(view, "#security-master-data", "EUR") assert has_element?(view, "#security-master-data", "SYN.X") + + assert has_element?( + view, + "#security-master-data-caption", + "Security master data table with identifiers and provider mapping." + ) end test "shows buy transactions for the selected security", %{ @@ -99,6 +105,12 @@ defmodule PortfolixirWeb.SecurityDetailLiveTest do assert has_element?(view, "#security-transactions", "125") assert has_element?(view, "#security-transactions", "Initial buy") + assert has_element?( + view, + "#security-transactions-caption", + "Transaction history table with date, type, account, quantity, price, amount, currency, and notes." + ) + assert has_element?(view, "#security-price-chart-svg") assert has_element?(view, "#security-chart-marker-0[data-type='buy']") end @@ -241,6 +253,12 @@ defmodule PortfolixirWeb.SecurityDetailLiveTest do assert has_element?(view, "#security-position-list", "Secondary depot") assert has_element?(view, "#security-position-list", "8") assert has_element?(view, "#security-position-list", "5") + + assert has_element?( + view, + "#security-position-list-caption", + "Current position table with securities account and quantity." + ) end test "does not include transactions from other securities", %{ @@ -403,6 +421,12 @@ defmodule PortfolixirWeb.SecurityDetailLiveTest do assert has_element?(view, "#security-fund-documents", "failed") assert has_element?(view, "#security-fund-documents", "Unable to read text") + assert has_element?( + view, + "#security-fund-document-list-caption", + "Fund documents table with filename, type, source, extraction status, and creation date." + ) + assert has_element?( view, "#security-fund-documents a[href=\"/fund-documents/#{first_document.id}/allocations/review\"]"
+ <%= gettext("Transaction history table with date, type, account, quantity, price, amount, currency, and notes.") %> +
<%= gettext("Date") %>