-
Notifications
You must be signed in to change notification settings - Fork 30
createPDF function hangs in Linux runners (but works fine in Windows) #14
Description
The createPDF function in pdfWriter hangs when being executed by Linux runners, this even causes the Manual Test and Build and Test workflows to fail (given they are using a Linux image themselves). Interestingly enough, this issue doesn't affect Windows runners.
The root cause seems to be related to the parameters being passed when calling puppeteer.launch, I have a PR open that fixes this issue, but here is some code I borrowed from stackoverflow if you are in the middle of some refactoring and don't feel like going through all the commits:
return puppeteer.launch({
executablePath: revisionInfo.executablePath,
headless: true,
devtools: true,
args: [
'--ignore-certificate-errors',
'--no-sandbox',
'--disable-setuid-sandbox',
'--disable-accelerated-2d-canvas',
'--disable-gpu'
]
})I have tested this fix for both Linux and Windows runners. While this is not a critical issue, it is quite a head-scratcher given that it silently fails. In our case we would find some workflows with reports generated and others without any reports.