Skip to content

Commit 7a49a96

Browse files
tianzhouclaude
andcommitted
fix: comment out PG 17+ transaction_timeout in issue_191 pgdump.sql
The SET transaction_timeout parameter was introduced in PostgreSQL 17 but was left uncommented in this test fixture, causing failures on PG 14-16. Also document the version-specific SET parameter gotcha in CLAUDE.md. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent b9ef897 commit 7a49a96

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

CLAUDE.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -288,6 +288,8 @@ Each test case contains: `old.sql` (starting state), `new.sql` (desired state),
288288
- Schema examples: `bytebase/`, `employee/`, `sakila/`, `tenant/`
289289
- Issue regressions: `issue_125_*`, `issue_133_*`, `issue_183_*`, `issue_191_*`, `issue_252_*`, `issue_275_*`, `issue_307_*`, `issue_318_*`, `issue_320_*`, `issue_78_*`, `issue_80_*`, `issue_82_*`, `issue_83_*`
290290

291+
**pgdump.sql version gotcha**: `pgdump.sql` files are executed against all supported PostgreSQL versions (14-18). Version-specific SET parameters like `SET transaction_timeout = 0;` (PG 17+) must be commented out, e.g. `-- SET transaction_timeout = 0;`, or the test will fail on older versions.
292+
291293
### Include Tests (`testdata/include/`)
292294

293295
8 categories: `domains/`, `functions/`, `materialized_views/`, `procedures/`, `sequences/`, `tables/`, `types/`, `views/`

testdata/dump/issue_191_function_procedure_overload/pgdump.sql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88
SET statement_timeout = 0;
99
SET lock_timeout = 0;
1010
SET idle_in_transaction_session_timeout = 0;
11-
SET transaction_timeout = 0;
11+
-- transaction_timeout is introduced in PG 17
12+
-- SET transaction_timeout = 0;
1213
SET client_encoding = 'UTF8';
1314
SET standard_conforming_strings = on;
1415
SELECT pg_catalog.set_config('search_path', '', false);

0 commit comments

Comments
 (0)