fix: strip quotes from type names in view dependency detection (#337)

* fix: strip quotes from type names in view dependency detection

When a function returns a quoted type like SETOF public."ViewName",
the extractBaseTypeName function was not stripping the double quotes.
This caused the lookup in functionReferencesNewView to fail because
the view lookup map stores unquoted names (e.g., public.viewname).

As a result, functions with quoted return types were not detected as
having view dependencies, causing them to be created before the views
they depend on, leading to "type does not exist" errors.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* test: add unit tests for extractBaseTypeName

Add tests for the extractBaseTypeName function to verify correct
handling of quoted identifiers in type expressions. Tests cover:
- Simple types
- SETOF prefix with schema-qualified types
- Quoted type names (e.g., SETOF public."ViewName")
- Quoted schema and type names
- Array notation
- Combined cases (SETOF + quoted + array)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

Author: FFX3

internal/diff/diff.go

@@ -1938,7 +1938,7 @@ func functionReferencesNewView(fn *ir.Function, newViews map[string]struct{}) bo
 }
 
 // extractBaseTypeName extracts the base type name from a type expression,
-// stripping SETOF prefix and array notation.
+// stripping SETOF prefix, array notation, and double quotes from identifiers.
 func extractBaseTypeName(typeExpr string) string {
 	t := strings.TrimSpace(typeExpr)
 	// Strip SETOF prefix (case-insensitive)
@@ -1949,6 +1949,8 @@ func extractBaseTypeName(typeExpr string) string {
 	for len(t) > 2 && t[len(t)-2:] == "[]" {
 		t = t[:len(t)-2]
 	}
+	// Strip double quotes from identifiers (e.g., public."ViewName" -> public.ViewName)
+	t = strings.ReplaceAll(t, "\"", "")
 	return t
 }
 

internal/diff/type_extract_test.go

@@ -0,0 +1,61 @@
+package diff
+
+import "testing"
+
+func TestExtractBaseTypeName(t *testing.T) {
+	tests := []struct {
+		name     string
+		typeExpr string
+		want     string
+	}{
+		{
+			name:     "simple type",
+			typeExpr: "integer",
+			want:     "integer",
+		},
+		{
+			name:     "SETOF simple type",
+			typeExpr: "SETOF actor",
+			want:     "actor",
+		},
+		{
+			name:     "SETOF with schema",
+			typeExpr: "SETOF public.actor",
+			want:     "public.actor",
+		},
+		{
+			name:     "SETOF with quoted type name",
+			typeExpr: `SETOF public."ViewName"`,
+			want:     "public.ViewName",
+		},
+		{
+			name:     "SETOF with quoted schema and type",
+			typeExpr: `SETOF "Schema"."ViewName"`,
+			want:     "Schema.ViewName",
+		},
+		{
+			name:     "quoted type only",
+			typeExpr: `"MyType"`,
+			want:     "MyType",
+		},
+		{
+			name:     "array type",
+			typeExpr: "integer[]",
+			want:     "integer",
+		},
+		{
+			name:     "SETOF quoted type with array",
+			typeExpr: `SETOF public."ViewName"[]`,
+			want:     "public.ViewName",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got := extractBaseTypeName(tt.typeExpr)
+			if got != tt.want {
+				t.Errorf("extractBaseTypeName(%q) = %q, want %q", tt.typeExpr, got, tt.want)
+			}
+		})
+	}
+}