Excessive parameter use in `get_or_create_non_empty_tags_list `

[mdashlw]

get_or_create_non_empty_tags_list function tries to INSERT every tag with 12 parameters each, most of which are unnecessary.

philomena/lib/philomena/tags.ex

Line 122 in b7a95ee

|> Multi.insert_all(

✅ :slug              - needed
✅ :name              - needed
✅ :category          - needed
❌ :images_count      - defaults to 0
❌ :description       - defaults to empty
❌ :short_description - defaults to empty
✅ :namespace         - needed
✅ :name_in_namespace - needed
❌ :image             - defaults to NULL
❌ :image_format      - defaults to NULL
❌ :image_mime_type   - defaults to NULL
❌ :mod_notes         - defaults to NULL

[liamwhite]

We can fix this, but I think the smarter approach to fixing the underlying issue would be a proper bulk insert rather than any n-fold reduction in parameter count (since then it would simply not matter how many tags are fetched)

[mdashlw]

We can fix this, but I think the smarter approach to fixing the underlying issue would be a proper bulk insert rather than any n-fold reduction in parameter count (since then it would simply not matter how many tags are fetched)

Please elaborate how a proper bulk insert looks like. I don't know how else you could do one

[liamwhite]

Okay, I researched it more thoroughly and it's not applicable because the way you do that kind of bulk insert is with COPY - disregard my comment