Summary
Following the fix in #60, the "Show Rich Markdown Diff" button in the editor title bar now successfully renders diffs for committed changes.
However, when right-clicking inside a committed revision diff editor, the editor context menu still does not display the "Show Rich Markdown Diff" command.
Current Behavior
- Editor title bar button: Visible and Working (via
isInDiffEditor condition in package.json)
- Right-click editor context menu: Missing (via
rich-markdown-diff.canShowRenderedDiff context key condition)
Suggested Fix
Update updateRenderedDiffContext (or the underlying context key resolution) in src/extension.ts to recognize active diff tabs addressing git revision comparisons (getRevisionComparison / getActiveDiffTabUriPair), so that rich-markdown-diff.canShowRenderedDiff is set to true when viewing a committed Markdown diff.
@wolframarnold As discussed in #60, I've opened this follow-up issue to track the context menu update. If you're interested in working on a PR for this, please feel free to take it on! No pressure at all, and thank you again for your great contribution.
Summary
Following the fix in #60, the "Show Rich Markdown Diff" button in the editor title bar now successfully renders diffs for committed changes.
However, when right-clicking inside a committed revision diff editor, the editor context menu still does not display the "Show Rich Markdown Diff" command.
Current Behavior
isInDiffEditorcondition inpackage.json)rich-markdown-diff.canShowRenderedDiffcontext key condition)Suggested Fix
Update
updateRenderedDiffContext(or the underlying context key resolution) insrc/extension.tsto recognize active diff tabs addressing git revision comparisons (getRevisionComparison/getActiveDiffTabUriPair), so thatrich-markdown-diff.canShowRenderedDiffis set totruewhen viewing a committed Markdown diff.@wolframarnold As discussed in #60, I've opened this follow-up issue to track the context menu update. If you're interested in working on a PR for this, please feel free to take it on! No pressure at all, and thank you again for your great contribution.