Skip to content

Commit 2680f88

Browse files
committed
Fix as suggested in #22078 (comment)
1 parent 3f24420 commit 2680f88

2 files changed

Lines changed: 20 additions & 3 deletions

File tree

ext/dom/xpath.c

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,24 @@
3535

3636
#ifdef LIBXML_XPATH_ENABLED
3737

38+
static dom_object *dom_xpath_intern_for_doc(dom_xpath_object *xpath_obj, xmlDocPtr doc)
39+
{
40+
if (xpath_obj->dom.document && xpath_obj->dom.document->ptr == doc) {
41+
return &xpath_obj->dom;
42+
}
43+
HashTable *node_list = xpath_obj->xpath_callbacks.node_list;
44+
if (node_list) {
45+
zval *entry;
46+
ZEND_HASH_PACKED_FOREACH_VAL(node_list, entry) {
47+
dom_object *obj = Z_DOMOBJ_P(entry);
48+
if (obj->document && obj->document->ptr == doc) {
49+
return obj;
50+
}
51+
} ZEND_HASH_FOREACH_END();
52+
}
53+
return &xpath_obj->dom;
54+
}
55+
3856
void dom_xpath_objects_free_storage(zend_object *object)
3957
{
4058
dom_xpath_object *intern = php_xpath_obj_from_obj(object);
@@ -357,7 +375,8 @@ static void php_xpath_eval(INTERNAL_FUNCTION_PARAMETERS, int type, bool modern)
357375

358376
node = php_dom_create_fake_namespace_decl(nsparent, original, &child, parent_intern);
359377
} else {
360-
php_dom_create_object(node, &child, &intern->dom);
378+
dom_object *parent = dom_xpath_intern_for_doc(intern, node->doc);
379+
php_dom_create_object(node, &child, parent);
361380
}
362381
add_next_index_zval(&retval, &child);
363382
}

ext/dom/xpath_callbacks.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -440,8 +440,6 @@ static zend_result php_dom_xpath_callback_dispatch(php_dom_xpath_callbacks *xpat
440440
obj = Z_DOMOBJ_P(&callback_retval);
441441
nodep = dom_object_get_node(obj);
442442
valuePush(ctxt, xmlXPathNewNodeSet(nodep));
443-
/* keep document alive */
444-
php_libxml_increment_doc_ref((php_libxml_node_object *) obj, nodep->doc);
445443
} else if (Z_TYPE(callback_retval) == IS_FALSE || Z_TYPE(callback_retval) == IS_TRUE) {
446444
valuePush(ctxt, xmlXPathNewBoolean(Z_TYPE(callback_retval) == IS_TRUE));
447445
} else if (Z_TYPE(callback_retval) == IS_OBJECT) {

0 commit comments

Comments
 (0)