ext/reflection: only warn instead of throwing exceptions on bad __isset

Author: zaaarf

ext/reflection/php_reflection.c

@@ -6725,8 +6725,9 @@ ZEND_METHOD(ReflectionProperty, isReadable)
 		if (ce->__get) {
 			if (obj && ce->__isset) {
 				if (ce->__isset->common.fn_flags & ZEND_ACC_RETURN_REFERENCE) {
-					zend_throw_exception(reflection_exception_ptr, "__isset should not return a reference", 0);
-					RETURN_THROWS();
+					//php_error_docref(NULL, E_WARNING, "__isset unexpectedly returned a reference!");
+					zend_error(E_WARNING, "__isset unexpectedly returned a reference!");
+					RETURN_FALSE;
 				}
 
 				uint32_t *guard = zend_get_property_guard(obj, ref->unmangled_name);

ext/reflection/tests/gh22000.phpt

@@ -21,19 +21,21 @@ class TestClass {
 
 
 function test($class) {
-    try {
-        $rc = new ReflectionClass($class);
-        foreach ($rc->getProperties() as $rp) {
-            echo $rp->getName() . ' from global: ';
-            var_dump($rp->isReadable(null, new $class));
-        }
-    } catch(\Exception $ex) {
-        echo $ex->getMessage();
+    $rc = new ReflectionClass($class);
+    foreach ($rc->getProperties() as $rp) {
+        echo $rp->getName() . ' from global:';
+        var_dump($rp->isReadable(null, new $class));
     }
 }
 
 test('TestClass');
 ?>
 --EXPECTF--
-a from global: bool(false)
-b from global: __isset should not return a reference
+a from global:bool(false)
+b from global:
+Warning: __isset unexpectedly returned a reference! in %s/ext/reflection/tests/gh22000.php on line %d
+bool(false)
+c from global:
+Warning: __isset unexpectedly returned a reference! in %s/ext/reflection/tests/gh22000.php on line %d
+bool(false)
+