apply suggestions from code review

Author: LamentXU123

ext/soap/php_encoding.c

@@ -2708,13 +2708,16 @@ static zval *to_zval_array(zval *ret, encodeTypePtr type, xmlNodePtr data)
 			/* Increment position */
 			i = dimension;
 			while (i > 0) {
-			  i--;
+				i--;
 				if (pos[i] == INT_MAX) {
+					efree(dims);
+					efree(pos);
+					zval_ptr_dtor(ret);
 					soap_error0(E_ERROR, "Encoding: array index out of range");
 				}
-			  pos[i]++;
+				pos[i]++;
 				if (pos[i] < dims[i]) {
-				  break;
+					break;
 				}
 				if (i > 0) {
 					pos[i] = 0;

ext/soap/tests/soap_array_index_overflow.phpt

@@ -48,6 +48,20 @@ function test_overflow(string $name, string $response): void {
     }
 }
 
+function test_boundary_position(): void {
+    $client = new TestSoapClient(NULL, [
+        'location' => 'test://',
+        'uri' => 'http://example.org/',
+        'exceptions' => true,
+    ]);
+    $client->response = soap_response(
+        'SOAP-ENC:arrayType="xsd:string[1]" xsi:type="SOAP-ENC:Array"',
+        'SOAP-ENC:position="[2147483646]"'
+    );
+
+    var_dump($client->test());
+}
+
 test_overflow(
     'arrayType',
     soap_response('SOAP-ENC:arrayType="xsd:string[2147483648]" xsi:type="SOAP-ENC:Array"')
@@ -62,8 +76,14 @@ test_overflow(
     'position',
     soap_response('SOAP-ENC:arrayType="xsd:string[1]" xsi:type="SOAP-ENC:Array"', 'SOAP-ENC:position="[2147483647]"')
 );
+
+test_boundary_position();
 ?>
 --EXPECT--
 arrayType: SOAP-ERROR: Encoding: array index out of range
 offset: SOAP-ERROR: Encoding: array index out of range
 position: SOAP-ERROR: Encoding: array index out of range
+array(1) {
+  [2147483646]=>
+  string(5) "value"
+}