Skip to content

Commit 3fea5ce

Browse files
committed
Rearrange code to make cleanup code simpler
1 parent 2f3becf commit 3fea5ce

2 files changed

Lines changed: 21 additions & 28 deletions

File tree

Zend/zend_vm_def.h

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8829,7 +8829,6 @@ ZEND_VM_COLD_CONST_HANDLER(121, ZEND_STRLEN, CONST|TMP|CV, ANY)
88298829
strict = EX_USES_STRICT_TYPES();
88308830
do {
88318831
if (EXPECTED(!strict)) {
8832-
zend_string *str;
88338832
zval tmp;
88348833

88358834
if (UNEXPECTED(Z_TYPE_P(value) == IS_NULL)) {
@@ -8843,12 +8842,12 @@ ZEND_VM_COLD_CONST_HANDLER(121, ZEND_STRLEN, CONST|TMP|CV, ANY)
88438842
}
88448843

88458844
ZVAL_COPY(&tmp, value);
8846-
if ((str = zend_parse_arg_str_weak(&tmp, 1)) != NULL) {
8845+
zend_string *str = zend_parse_arg_str_weak(&tmp, 1);
8846+
zval_ptr_dtor(&tmp);
8847+
if (str) {
88478848
ZVAL_LONG(EX_VAR(opline->result.var), ZSTR_LEN(str));
8848-
zval_ptr_dtor(&tmp);
88498849
break;
88508850
}
8851-
zval_ptr_dtor(&tmp);
88528851
}
88538852
if (!EG(exception)) {
88548853
zend_type_error("strlen(): Argument #1 ($string) must be of type string, %s given", zend_zval_value_name(value));

Zend/zend_vm_execute.h

Lines changed: 18 additions & 24 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)